Currently, I have FC enabled, but I also use Quote module and it appears that using the Quote link produces a reply that is child of the quoted comment.
I don't know if it makes more sense to alter Flatcomments to work w/the Quote button or to alter Quote to check for Flatcomments, but it would be great to get these working together.

(If it matters, I have Advanced Forum installed)

Comments

aharown07’s picture

aharown07 commented

Nothings happening on this on the Quote side yet... any chance something can be done w/Flatcomments? I'd be grateful even for some clues on how I might patch one or the other. No idea how to go about that, but I'm much in need of a solution. For Comment Mover to work reliably in my situation I need to preserve flatness and I can't do that unless I can use Quote and still stay flat.

dragonwize’s picture

dragonwize commented
Status: Active » Postponed (maintainer needs more info)

Aaron, I think there may be confusion. I just ran my own tests and quote.module and flatcomments.module are working fine together.

When you click the "quote" link the text of that comment is included with the new comments as a reference to what the user is talking about.

However, in the backend that comment is NOT actually recorded as a reply or parent of your comment. So flatcomments is doing its job and there won't be issues with using comment mover (outside the known ones anyway).

If you are experiencing a different issue please provide more information otherwise we can close this issue.

aharown07’s picture

aharown07 commented

Interesting. I thought I repeated that one several times. Will check again.

OK, in my test, when I use Quote, the new comment takes it's place below the quoted one, indented rather than at the end of the thread (if I have Drupal's threaded display enabled).
Verified that I have Flatcomments enabled.

Could it have to do w/Advanced Forum? It may be that using AF w/threaded display (which they don't recommend for AF... I just turned it on so I could see what Comment Mover and other modules were doing) breaks it somehow? Will do some more testing and see what I can find out.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

I just looked in my comments table and the only ones with pid > 0 are the quoted ones. This is D5, though, not D6. I don't see what AF could have to do with this... AF isn't involved in adding comments. I don't have time right now, though, to dig in and see at what point the pid is getting assigned. Probably won't for at least a few days.

Michelle

aharown07’s picture

aharown07 commented
Status: Postponed (maintainer needs more info) » Closed (won't fix)

OK, I think I've got it now.
Maybe I'm losing my mind but I seem to recall that Flatcomments used to be enabled by selecting a checkbox in the node type that said something like"make all comments replies to the node" ... but now the readme just says "choose flat expanded or flat collapsed." (Maybe I'm remembering 5.x?)

So when I turned flatness off in the display I disabled Flatcomments?

In any case, if I turn flat display on, use Quote then turn threaded on again, the new Quote-generated comment appears at the end of the thread and not as child to any comment.

So apparently this was all "user error" on my part.

aharown07’s picture

aharown07 commented
Status: Closed (won't fix) » Closed (fixed)
michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

So you're saying this isn't broken anymore in D6? If that's the case, I won't worry about it. I can live with it for a few more months in D5. Thanks for bringing it to my attention, though. I never noticed it was broken and now I know to reset them to 0 in the db.

Michelle

dragonwize’s picture

dragonwize commented
Status: Closed (fixed) » Closed (won't fix)

You aren't going crazy aaron. That is a the way the new flatcomments both 5 & 6 work. I removed the checkbox as a usability upgrade as most of the time if you want flat display you want flatcomments as well. In the upcoming flatcomments release the we spoke about on IRC though it will have a 3rd option that mixes the 2 to support some of the upcoming features in the new comment mover.

@Michelle: I haven't tested Quote.module in D5 but I looked at the code and both quote.module and flatcomments are very simple modules and quote isn't messing with pid. So unless the comment form api in D5 is changing something it should work exactly the same as D6. If you find out what is causing it though, feel free to re-open this issue.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

@dragonwize: I haven't dug into it. All I did was run "SELECT * FROM comments WHERE pid>0" and looked at the results and it was a stream of quoted comments. That seemed to corroborate aharown07's findings and I didn't go any further.

I'm fine with the won't fix on this. If it turns out to be a problem once I get to D6, I'll investigate. In the mean time, I can reset the pids to 0 easily enough in the database.

Thanks,

Michelle