Closed (fixed)
Project:
CitizenSpeak
Version:
master
Component:
Code
Priority:
Critical
Category:
Task
Assigned:
Reporter:
Created:
12 Jan 2006 at 02:36 UTC
Updated:
9 Oct 2008 at 16:36 UTC
Jump to comment: Most recent file
Here is the update to 4.7.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | citizenspeak_update47_tg.patch | 35.86 KB | thierry_gd |
| #4 | citizenspeak_update47.patch.txt | 37.15 KB | gordon |
| #2 | citizenspeak_0.patch | 38.59 KB | drumm |
| citizenspeak.patch | 38.61 KB | drumm |
Comments
Comment #1
anarcat commentedI don't have a lot of experience in 4.7-conversions and I do not own this module, but this looks pretty good.
However, why comment out code instead of just removing it?
this looks a bit weird to me, esp. since it effectively disables the form validation on view.
Comment #2
drummThe commented code is now removed. The validation is done through formapi's hook-like system so it is not removing the validation step.
Comment #3
bdimaggioHello there -- I have been tinkering with a 4.7 site that I need to put up pretty soon, assuming that I can stick with 4.7 and still use CitizenSpeak... and then I read the last line of the current project description. So I tried to apply this patch to the CitizenSpeak version presently in CVS, and it barfed. Presumably that's because the patch was based on the version of CitizenSpeak that was current at the time the patch was written...? Anyway, the upshot here is that I'm wondering whether I should abandon my quixotic quest to use CS with Drupal 4.7, or whether there's hope. Anybody got ideas?
thanks!
Comment #4
gordon commentedHere is an updated version of citizenspeak.
I have some other ideas, and I think my client may pay to have me intergrate citizenspeak with my pdf letter creation modules so that letters can be printed out and posted.
Comment #5
jarea commentedI tried applying this patch and received the following failures:
Contents of reject file are displayed below:
Comment #6
thierry_gd commentedIt would also be nice to have a .install file for automating the creation of the DB tables in 4.7 version of drupal
Comment #7
thierry_gd commentedJust added a .install file for automatic installation of the DB tables ==> http://drupal.org/node/92566
Also corrected the problems with the patches which had been previously submitted ==> cf. attached file
Can't wait to see these files commited (don't have a CVS access for this module)
Comment #8
thierry_gd commentedComment #9
patchak commentedAny chance to have a official 4.7 branch soon?
Thanks for the great work, can,t wait to test the 4.7 release!
Comment #10
ahneill commentedThe 4.7 version is still not available at the citizenspeak module main page. Looking forward to testing the 4.7 version ASAP!
Comment #11
allanx commentedIs this module compatible with 5.1?
Comment #12
matt2000 commented