Hi there,

At present, field ordering, on product node pages, is handled through admin/store/settings/product. The form on that page is not using drag-and-drop for weighting and probably should be.

Fortunately, there is also the possibility that we expose the fields to CCK allowing an admin to change field ordering per product content type and include the fields provided outside of ubercart.

I'll work on a patch and i'm aiming for it to be done for 2.0.

Comments

rszrama’s picture

Status: Active » Postponed

I doubt we'll put a change this significant into 2.0 now that we've moved into RC territory. However, the goal for 3.0 is definitely to introduce a dependency on CCK, so that problem should solve itself.

sammys’s picture

I don't consider this a significant patch because it's purely cosmetic. It doesn't affect transactions, orders or anything requiring large amounts of testing. Instead, you can easily view that it's working properly within, say, 5 minutes.

It does bring UC up-to-date with present versions of Drupal and CCK now rather than in the next version.

rszrama’s picture

We can always review what you come up with, but we're pretty aggressively pushing for a 2.0 release, so the patches we're committing are more about removing and fixing things than adding in new functionality.

sammys’s picture

After looking deeper into it, this baby is better left for 3.x. Added field ordering was trivial. Adding per-field per-content type display settings (on cck display fields page) looks to be impossible for non-cck fields. Bummer.

Thanks for responding to it anyway Ryan!

tr’s picture

Version: 6.x-2.0-rc1 » 7.x-3.x-dev
Category: feature » task
Status: Postponed » Active

Moving to the 7.x-3.x queue. I believe this is being addressed now, as it's a natural consequence of moving from CCK to Fields in Drupal 7.

SeanBannister’s picture

Sub

webservant316’s picture

subscribe

actually just realizing this is more important to me.
is there a patch anywhere that allows us to order all the fields on a product node?
I have fields showing up in awkward places and I cannot move them.

Thanks for any help,

Jeff

webservant316’s picture

Is this patch the solution for Ubercart 2.2?

http://drupal.org/node/333085

apparently, not. just installed it a second time and could not get it to work.

fadiwissa’s picture

Here's a good module related to this thread's discussion (adding custom CCK field attributes to Ubercart products)...
http://drupal.org/node/923708

fadiwissa’s picture

Here's a good module related to this thread's discussion (adding custom CCK field attributes to Ubercart products)...
http://drupal.org/node/923708

trungonly’s picture

trungonly’s picture

Version: 7.x-3.x-dev » 6.x-2.4
Status: Active » Fixed
tr’s picture

Version: 6.x-2.4 » 7.x-3.x-dev
Status: Fixed » Active
longwave’s picture

Title: Move product field ordering to CCK manage fields » Move product field ordering to standard field display management
Category: task » feature
Status: Active » Needs review
StatusFileSize
new23.1 KB

Patch attached that removes the separate product field settings page and uses the standard field settings page instead. Also fixes up the teaser display settings when uc_product is installed or upgraded. Needs testing!

webservant316’s picture

i just installed ubercart 2.4 and was surprised that this was not fixed in that release either.

longwave’s picture

A patch for 2.x can be found in #333085: Field weight order using CCK interface but is not yet ready to commit.

longwave’s picture

StatusFileSize
new21.95 KB

Updated patch against latest -dev, and changing this to a bug after #1184110: SKU does not display

longwave’s picture

Category: feature » bug
Issue tags: +Release blocker

Adding tag; we should fix this before release.

giupenni’s picture

To apply this patch I must use 7.x-3.x-dev ?

I can't applied the patch against 7.x-3.x-dev:

$ patch -p1 < ../443926-product-field-display_0.patch
patching file uc_product/uc_product.admin.inc
patching file uc_product/uc_product.install
patching file uc_product/uc_product.module
patching file uc_product_kit/uc_product_kit.install
patching file uc_product_kit/uc_product_kit.module
Hunk #3 FAILED at 643.
1 out of 3 hunks FAILED -- saving rejects to file uc_product_kit/uc_product_kit.module.rej

Thanks!

longwave’s picture

You need the -dev release from git, the tarball hasn't yet updated with a change I committed earlier. But you still should be able to test products with the above failure, product kits won't work quite right though.

giupenni’s picture

I have applied the patch but the bug #1184110: SKU does not display still persist

longwave’s picture

For me, once the patch is installed, I can visit /admin/structure/types/manage/product/display/teaser and change SKU to Visible to make it show up on teasers. So you're saying this doesn't happen for your case?

giupenni’s picture

Well, If I change (in /admin/structure/types/manage/product/display/teaser) SKU to Visible it shows "only" the label of SKU but not its value.
I have the same problem in the full node.

longwave’s picture

Reopening your other issue, as this patch is for a different problem; at least the SKU label shows up on teasers with this patch in place, which is a little better than before.

giupenni’s picture

After I have update the module with this patch is disappeared the content of Catalog block.

longwave’s picture

Strange, that doesn't happen for me, and this patch doesn't touch that code. Does the block not show up at all, or is the title there but the rest is empty?

giupenni’s picture

The rest is empty.

giupenni’s picture

I restored the beta and the block works fine.

longwave’s picture

And it goes back to normal if you revert the patch?

giupenni’s picture

It's strange, works only with "my" previous Ubercart 3.0-beta3, 2011-5-26 ...if I download again Ubercart 3.0-beta3, 2011-5-26 it not works but if I use my backup works.

longwave’s picture

Status: Needs review » Fixed

Committed this, as having two separate places to manage product display fields, one of which didn't work as expected, and one of which was inflexible compared to Drupal core, just didn't make sense.

I can't reproduce the above catalog issue, please open a new issue if this is still a problem.

Status: Fixed » Closed (fixed)
Issue tags: -Release blocker

Automatically closed -- issue fixed for 2 weeks with no activity.