Posted by Aron Novak on April 24, 2009 at 5:27pm
3 followers
Jump to:
| Project: | OpenID Client SREG |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Aron Novak |
| Status: | closed (fixed) |
Issue Summary
With the big changes in the openid stack (http://groups.drupal.org/node/21221), openid_client_sreg stopped working.
Here is a patch what makes the module conforming to the new stack idea. The mapping is done via the openid_cp_field (via a hook, so no hard dependency).
I tested and it works fine. More testers wanted :)
| Attachment | Size |
|---|---|
| openid_client_sreg_make_work_with_openid_stack.patch | 10.31 KB |
Comments
#1
Related (depending patches): #444170: Hook changes and client side SReg support and #444204: Hook change because of client side SReg support
#2
#3
I see this patch removes an implementation of hook_openid_response() and replaces it with a custom callback on openid/authenticate - just like OpenID Client AX does.
We (Aron and I) discussed this on IM and we found that hook_openid_response() is not invoked by any existing OpenID module but it is being suggested here [#329493].
In favor of a functioning OpenID stack I think it's a good idea to replace the hook_openid_response() implementation with a callback on openid/authenticate just like this patch suggests.
We should start thinking about adding this hook_openid_response() into openid.module though.
#4
Ok, just confirmed with Darren, #3 is ok with him, too.
We need to work on #319840: Add hook to the OpenID module for returning data to clean up this issue.
#5
Just did another round of tests - RTBC.
#6
Committed. Thank you!
#7
Automatically closed -- issue fixed for 2 weeks with no activity.