I have patched the source to use the SimpleXML library. I've found that MiniXML is unreliable, often throwing errors on normal imports, and also a seemingly excessive memory requirement. I've done some preliminary tests, but would appreciate tests on your data!

It requires a little helper code, as SimpleXML doesn't seem to have any built-in functionality for arrays, but I don't think the code is too complex. Suggestions/critique are very welcome.

CommentFileSizeAuthor
importexportapi.simpleXML.patch5.34 KBcha0s

Comments

cha0s’s picture

No objections = committing...

Anonymous’s picture

Well, not really. I haven't had time to review. Most of my spare time is spent on xmlsitemap at the moment.

cha0s’s picture

It's cool. Take a little longer if you need it.

cha0s’s picture

Just poking the fire to let you know I'm gonna commit this in the upcoming week if there has been no movement.

Anonymous’s picture

Give me until Monday 19:00 UTC.

Anonymous’s picture

Version: master » 6.x-1.x-dev
Status: Needs review » Needs work

Trying to apply this patch to the 6.x-1.x-dev branch gives the following:

$ patch -p0 < /temp/importexportapi-drupal6.2.patch 
can't find file to patch at input line 4
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -urp importexportapi-5.x/definitions/importexportapi_block.inc importexportapi/definitions/importexportapi_block.inc
|--- importexportapi-5.x/definitions/importexportapi_block.inc  2007-03-25 17:19:56.000000000 -0500
|+++ importexportapi/definitions/importexportapi_block.inc      2008-10-31 11:07:15.000000000 -0500
--------------------------
File to patch: 

cha0s’s picture

What the heck is your problem dude? I made the patch against HEAD and then you reassign the version and say it won't apply?

Forget it, I'm starting a fork.

Anonymous’s picture

HEAD isn't the current development path. 6.x-1.x-dev is the current development path. HEAD isn't in sync with the current development path. I'm not opposed to the patch, but it needs to be tested before being committed.

Anonymous’s picture

HEAD is listed as a version because Jaza created a HEAD release which is no longer supported but I can't remove it from the selection of versions.