SimpleXML support
cha0s - April 25, 2009 - 00:11
| Project: | Import / Export API |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | cha0s |
| Status: | needs work |
Jump to:
Description
I have patched the source to use the SimpleXML library. I've found that MiniXML is unreliable, often throwing errors on normal imports, and also a seemingly excessive memory requirement. I've done some preliminary tests, but would appreciate tests on your data!
It requires a little helper code, as SimpleXML doesn't seem to have any built-in functionality for arrays, but I don't think the code is too complex. Suggestions/critique are very welcome.
| Attachment | Size |
|---|---|
| importexportapi.simpleXML.patch | 5.34 KB |
#1
No objections = committing...
#2
Well, not really. I haven't had time to review. Most of my spare time is spent on xmlsitemap at the moment.
#3
It's cool. Take a little longer if you need it.
#4
Just poking the fire to let you know I'm gonna commit this in the upcoming week if there has been no movement.
#5
Give me until Monday 19:00 UTC.
#6
Trying to apply this patch to the 6.x-1.x-dev branch gives the following:
$ patch -p0 < /temp/importexportapi-drupal6.2.patchcan't find file to patch at input line 4
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -urp importexportapi-5.x/definitions/importexportapi_block.inc importexportapi/definitions/importexportapi_block.inc
|--- importexportapi-5.x/definitions/importexportapi_block.inc 2007-03-25 17:19:56.000000000 -0500
|+++ importexportapi/definitions/importexportapi_block.inc 2008-10-31 11:07:15.000000000 -0500
--------------------------
File to patch:
#7
What the heck is your problem dude? I made the patch against HEAD and then you reassign the version and say it won't apply?
Forget it, I'm starting a fork.
#8
HEAD isn't the current development path. 6.x-1.x-dev is the current development path. HEAD isn't in sync with the current development path. I'm not opposed to the patch, but it needs to be tested before being committed.
#9
HEAD is listed as a version because Jaza created a HEAD release which is no longer supported but I can't remove it from the selection of versions.