Needs work
Project:
Import / Export API
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
25 Apr 2009 at 00:11 UTC
Updated:
16 Sep 2009 at 13:21 UTC
Jump to comment: Most recent
I have patched the source to use the SimpleXML library. I've found that MiniXML is unreliable, often throwing errors on normal imports, and also a seemingly excessive memory requirement. I've done some preliminary tests, but would appreciate tests on your data!
It requires a little helper code, as SimpleXML doesn't seem to have any built-in functionality for arrays, but I don't think the code is too complex. Suggestions/critique are very welcome.
| Comment | File | Size | Author |
|---|---|---|---|
| importexportapi.simpleXML.patch | 5.34 KB | cha0s |
Comments
Comment #1
cha0s commentedNo objections = committing...
Comment #2
Anonymous (not verified) commentedWell, not really. I haven't had time to review. Most of my spare time is spent on xmlsitemap at the moment.
Comment #3
cha0s commentedIt's cool. Take a little longer if you need it.
Comment #4
cha0s commentedJust poking the fire to let you know I'm gonna commit this in the upcoming week if there has been no movement.
Comment #5
Anonymous (not verified) commentedGive me until Monday 19:00 UTC.
Comment #6
Anonymous (not verified) commentedTrying to apply this patch to the 6.x-1.x-dev branch gives the following:
Comment #7
cha0s commentedWhat the heck is your problem dude? I made the patch against HEAD and then you reassign the version and say it won't apply?
Forget it, I'm starting a fork.
Comment #8
Anonymous (not verified) commentedHEAD isn't the current development path. 6.x-1.x-dev is the current development path. HEAD isn't in sync with the current development path. I'm not opposed to the patch, but it needs to be tested before being committed.
Comment #9
Anonymous (not verified) commentedHEAD is listed as a version because Jaza created a HEAD release which is no longer supported but I can't remove it from the selection of versions.