Posted by cburschka on April 25, 2009 at 11:51pm
6 followers
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | system.module |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
| Issue tags: | API clean-up |
Issue Summary
As demonstrated by #357970: Undefined function token_get_all, Drupal suffers a fatal error when the php_tokenizer extension is not enabled (it's required by the code registry to parse PHP sources).
[#444718] therefore calls for this extension to be checked for during the install process. The obvious place for this central requirement is the system module, so this patch adds it to system_requirements.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| system-requirements-tokenizer.patch | 1.16 KB | Idle | Failed: Invalid PHP syntax in modules/system/system.install. | View details |
Comments
#1
It appears the filter will really only take project issue nodes.
#444718: 2009-04-25 & 26 Core patch review sprint
#2
The last submitted patch failed testing.
#3
Wow, I must have been tired. That, or having a testbot around made me lazy. :P
Here's a fix for the syntax error.
#4
This looks good to me. Just to point out, this requirement check at this point is OK, but we should include this requirement check at other points where hook_requirements is not reachable yet, the registry is not able to run if this extension is not enabled.
#5
Made some minor changes and committed this to CVS HEAD. Thanks!
#6
This requirement should be limited to the phases 'install' and 'update'. There's no point in showing it later on at runtime, because you won't see the status report page without Tokenizer.
#7
The registry is gone, and chx confirmed in IRC that class names are now identified with a regular expression.
So let's revert this requirement.
#8
This makes sense. token_get_all is not used anymore in core.
Perhaps coder_review module would need this requirement, because it uses this function.
#9
Committed to CVS HEAD. Thanks.
#10
Automatically closed -- issue fixed for 2 weeks with no activity.