Attached patch should fix the test failures on SQLite mentioned in http://drupal.org/node/303965#comment-1519896
| Comment | File | Size | Author |
|---|---|---|---|
| field_test_fix.patch | 883 bytes | yched |
Attached patch should fix the test failures on SQLite mentioned in http://drupal.org/node/303965#comment-1519896
| Comment | File | Size | Author |
|---|---|---|---|
| field_test_fix.patch | 883 bytes | yched |
Comments
Comment #1
moshe weitzman commentedComment #2
webchickHm. With this patch and SQLite I still get 383 passes, 10 fails, and 120 exceptions in test.text.
The badness starts with INSERT INTO {test_entity} (ftvid, fttype) VALUES (?, ?) - Array ( [0] => 0 [1] => test_bundle ) SQLSTATE[23000]: Integrity constraint violation: 19 column ftvid is not unique in drupal_write_record() and then goes on to fail the "Entity was created" check in TextFieldTestCase->_testTextfieldWidgets(), and then all hell breaks loose. ;)
I have no idea how else to share test results other than a big-ass 1.5 MB screenshot, so here ya go: http://img.skitch.com/20090426-enhtgucf3g99n4cs6f1g3sbhyt.png
There are instructions though for installing on SQLite in INSTALL.sqlite.txt and they work just dandy.
Comment #3
webchickI should note that with Damien's patch at http://drupal.org/node/303965#comment-1519896 the tests pass fine, but Moshe said that those lines were removed because of an edge case. Possible solutions:
1. Commit it anyway, and if said edge case rears its ugly heads, write tests for it so they don't again. ;)
2. Come up with a new idea, now that it's more clear what's causing the test to fail.
Comment #4
webchickBtw, it's still a bit unclear to me as to whether or not we need this fix in addition to Damien's. If we're fixing a specific bug here, we should probably write tests for it.
Comment #5
yched commentedThe remaining fails are explained by #303965-50: Enhanced data import - node_save() and user_save()
Comment #6
webchickCool. Committed to HEAD. Thanks. :)