Compatibility with Authorship module
prof1337 - April 26, 2009 - 04:53
| Project: | RealName |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | by design |
Description
I want to use both the Authorship and Realname modules on my site (the former to identify "Anonymous"/non-registered authors, the latter to display the real names of registered users). However, whenever I try to specify the Authorship on a node with the "Authored by" field left blank, the Realname module overrides the Authorship module and "Anonymous" is displayed as the author, rather than whatever I entered in the "Authorship" field.
Here's a patch against the latest dev version that keeps Realname from changing the author of a node if that name has already been modified by the Authorship module.
| Attachment | Size |
|---|---|
| realname_authorship.patch | 955 bytes |
#1
#2
Thank you for the patch.
I'm not crazy about adding module-specific checks into this module because there are potentially 2,000 such requests waiting. I also cannot possibly download and test every module that is requested.
"Module_exists" can be too expensive to put into hook_nodeapi. Is there a function that can be checked with "function_exists" that would be a faster and reliable way? For example "authorship_menu" probably exists.
#3
Good idea, Nancy. Here's an updated patch that checks for the "_authorship_name_rewrite" function instead of the Authorship module as a whole.
#4
I can't be adding support for 4,000 individual modules; it would be too big a performance impact. That module needs to properly use theme_username.