Add lightbox support
benpjohnson - April 26, 2009 - 21:06
| Project: | AddThis Button |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | wesku |
| Status: | needs review |
Jump to:
Description
Later versions of addthis (from 29th Jan) have been including a lightbox rather than a popup window.
I have attached a little patch to add a dropdown to admin allowing the user to select if they want to use version 152 (current version included in the module) or 200 (most recent version from the button code generator with lightbox).
I added this as an selector as I expect some people will want to keep the popup in place.
Hope you find it useful.
| Attachment | Size |
|---|---|
| addthis-version.patch | 2.88 KB |
#1
Thank you for the patch. I applied the patch and it is now part of latest 2.x-dev version for D6. Please test the latest dev. Next release of the module will be made in 1-2 weeks.
#2
I don't see why this module should maintain old versions of the addthis API, can't we just use the latest one?
Old APIs have bugs that are fixed in later ones, e.g. 152 doesn't work in google chrome.
BTW, the latest one is 250, if you go to addthis.com and create a button you'll see 250 in the generated code.
Let me know what do you think, so I can work on a patch for this.
Thanks.