Father/Mother reversed
danorton - April 26, 2009 - 21:21
| Project: | Family Tree 2 |
| Version: | 6.x-1.1 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
| Issue tags: | father, mother, parent, reversal, same-sex parents |
Jump to:
Description
My GEDCOM data came from PAF 5.2.18.0 and apparently the parent ordering is reversed from what this module expects. In the view on at least one record, the mother was listed as "Father" and the father was listed as "Mother."
The attached patch makes no assumption about the gender of the parent and looks it up. If it can't find it, it outputs "Parent".
There might be other places, such as the edit screens, but I'm tackling end-user issues, first.
(I note that this will also work correctly for same-sex parents.)
| Attachment | Size |
|---|---|
| view.inc_correct_parent.patch | 1.66 KB |
#1
This makes sure the data shows correctly and so for cases like same-sex parents this will be useful. I think the check should originate in the import though as other parts of the module depend on parent 1 being the father (I think). The import feature is currently being rewritten by sugardave so that it works far better! I will see if he can add this in.
#2
A little more on this. I'm working on a (currently) private module that changes the way family can import records...it's kind of just an API. That being said, I'm thinking that the best way to handle the mother/father, same-sex couples, etc. data should be handled in the family module (or any module that would display GEDCOM data).
I just saw an instance of this in some test data, where the mother is listed as the father and vice versa. I checked the records and it looks like it's the source GEDCOM file that is incorrect. The way it works is that a family record lists who the husband and wife are using the HUSB and WIFE tags. In the case I see, the HUSB tag refers to the INDI record of the mother.
So, if I run this test GEDCOM through GenealogyJ (OSS GEDCOM editor, it's pretty neat) and pass it through the validator, it shows me the records that have the wrong parents, and then you can swap them. Alternatively, you can look in the GEDCOM for the offending FAM record and swap the HUSB and WIFE pointers by hand.
I'm not certain if I want to automatically do the swap on someone's file when it's being imported (i.e. how much validation should I be doing on the data?)