Hi,

Every time I changed the setting for submitted by for comments and re-open the content type setting page, the value submitted before is missing. Could you help to take a look?

Regards,

Schturdark

CommentFileSizeAuthor
#5 submitted_by-445744.patch5.9 KBtobiasb

Comments

nancydru’s picture

Status: Active » Postponed (maintainer needs more info)

See #297688: Doesn't remember the submitted settings. This was a problem in 1.1, but it should be fixed in 1.2; are you certain that you have the 1.2 version in place? I believe the second line of the module should read:

// $Id: submitted_by.module,v 1.4 2008/10/21 14:49:42 nancyw Exp $
schturdark’s picture

Yes, I am certain the one I installed is version 1.2 because in the module list admin page, it shows the version as 1.2. The setting of submitted by for the node is alright, but the setting for the comment is not remembered.

nancydru’s picture

Please look in "function submitted_by_form_alter" and see if you see $default = variable_get('submitted_by_comment_'. $type, NULL);

schturdark’s picture

Yup, it is there. I saw it. Any other pointers how to solve this issue?

tobiasb’s picture

StatusFileSize
new5.9 KB

here is a patch for this + other bugsfixed

tobiasb’s picture

Status: Postponed (maintainer needs more info) » Needs review
nancydru’s picture

Why are you doing

-    $prefix .'month' => date('F', $date),
-    $prefix .'mon'   => date('M', $date),
+    $prefix .'month' => format_date($date, 'custom', 'F'),
+    $prefix .'mon'   => format_date($date, 'custom', 'M'),

They end up doing the same thing, but the original is less overhead.

tobiasb’s picture

date is only english and with format_date multilanguage.

nancydru’s picture

okay

nancydru’s picture

Status: Needs review » Fixed

committed. Thanks for the patch.

doomed’s picture

Status: Fixed » Active

Hello, according to NancyDru the patch provided on this thread and recently commmited to the Dev version should help fixing a problem i have with the way Dates are being displayed.

I have tested the latest Dev version from May 28th but the problem still happens.

Here's the situation:
After configuring the module to use something in the likes of "Published on [d] [month], [yyyy]." i noticed the Month field is no longer showing in the website's default language (Portuguese) but it's showing in English instead.

Before installing this module, the "Submitted line" was showing the Month name properly (in Portuguese).

I tried [month] and [mon], both are showing in English.

What can i do to fix this?

tobiasb’s picture

Status: Active » Fixed

[d] [month], [yyyy] ... are tokens from token modul #433486: Use format_date() for translatable date tokens. there is also a patch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nancydru’s picture

Status: Closed (fixed) » Active

Re-opened so I can actually take a look.

doomed’s picture

Hello NancyDru,

What's the current status on this?

I'm currently updating some parts of the same website i mentioned before (in the above post from 2009!) and since the Submitted_by date problem is still present, i would like to fix it.

I just tried the latest version of Submitted_by (dev version from Febrary 2011) and apparently nothing changed. The "language bug" is still there.

Then i updated Token module from 6.x-1.12 to the latest and greatest 6.x-1.16 (released this month May 2011) and it's still the same...

gbelot2003’s picture

Yep, the problem persist, does anybod have an actual patch for the 1.4 ? or is easyar to do it in the template.php????

--> sorry, I find where is the setting for this. is at content types...

nancydru’s picture

Issue summary: View changes
Status: Active » Closed (outdated)

6.x-1.x is no longer supported.