@TheCrow: At http://drupal.org/cvs?commit=186838 you "backported" some of the code from #408618: Twitter TinyURL into the DRUPAL-5 branch, but the API for url() changed between D5 and D6. The result is that the twitter links in the latest 5.x-1.x-dev release of service_links are totally busted. Can you:

A) please be a little more careful about what you backport to D5
B) consider a 5.x-2.x branch for backporting new features so that 5.x-1.x can remain (relatively) stable

? ;)

Thanks!
-Derek

CommentFileSizeAuthor
#1 445962-1.d5_url_twitter_link.patch1.09 KBdww

Comments

dww’s picture

dww
we/he/they
commented
Assigned: Unassigned » dww
Status: Active » Needs review
StatusFileSize
new 445962-1.d5_url_twitter_link.patch1.09 KB

... and C) commit this patch to the DRUPAL-5 branch ASAP? ;) Thanks, again.

TheCrow’s picture

TheCrow commented

A/B/C) This is a dev snapshot and not a stable release some mistake can always happen, just open an issue explaining the problem; recommendations sounds in this case useless and nosense, im enough careful to don't release a not-tested version as stable...
About service links... changes made in 1.x branch will be just the few and lightweight requested. 2.x dev plain is another story, 1.x branch will not have radical changes, please read around... it's all already wrote!!!

D) about the patch it's not complete, concerning another issue a piece is missing, but don't worry i'll fix it and commit all soon!

Thank you

Passionate_Lass’s picture

Passionate_Lass commented

Hello.

A client is running drupal 5.x and she wants twitter in her service links. I'm aware you're working to resolve the issue and have informed her. I'm just posting to say more than one person is interested in this fix. :)

Good work on the module.!

TheCrow’s picture

TheCrow commented
Status: Needs review » Fixed

committed it!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

plan9’s picture

plan9 commented

I thought this was committed to 5.x-1.x-dev?

I don't see it.

plan9’s picture

plan9 commented
Status: Closed (fixed) » Active

Changing status

TheCrow’s picture

TheCrow commented
Status: Active » Fixed

Read better please, this patch has been reworked and added long time ago!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.