Closed (fixed)
Project:
Privatemsg
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
27 Apr 2009 at 16:42 UTC
Updated:
14 Sep 2019 at 15:37 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
berdirThanks, but please re-create the file for the -dev release, there were many many changes since rc2.
Edit: Also, I can see from your profile that you do have CVS access. You should be able to commit that file yourself, every translations directory is writable for all developers.
Comment #2
frank ralf commentedHave just committed that file (http://drupal.org/node/293907#comment-1525810). Will re-create it for the dev release.
Frank
Comment #3
berdirYou should create a pot (and po) per submodule, so that only translations that are actually used are loaded when you enable the module.
Comment #4
frank ralf commentedHi Sascha,
I thought about that but think one pot/po file per module is a better approach because that way it's easier to maintain a consistent translation across all sub-modules.
Doing so won't create any overhead IMO. Drupal loads all provided translations at install time into the locales_source and locales_target tables in the database. The t() and locale() (http://api.drupal.org/api/function/locale/6) functions do a just-in-time translation for all the strings on a loaded page and will retrieve the translated strings from the database tables if present. If not, those strings will be added to those tables.
So creating separate pot/po files for each sub-module would only save some space in the database and even that only if you never installed that sub-module. As the current pot file is only about 12 KB I think this effect is negligible.
So I would suggest sticking to one pot/po file.
Cheers,
Frank
Comment #5
berdirAFAIK it's common to use multiple files, a example:
Same for CCK, FileField and many others.
Comment #6
frank ralf commentedAs I see this as a general issue I moved this discussion over to the Internationalization User Group (http://groups.drupal.org/node/21731).
Frank
Comment #7
litwol commentedI feel that it is always a good idea to keep related items together, the whole point of breaking the private message functionality into sub-modules is to give options and ultimate flexibility to the users of privatemsg. On that same note i think translations are not exempt from the same approach. Users shouldn't need to clutter their DB with translations that do not need to be translated for various reasons.
Comment #8
berdirThe attached patch does update the *.pot files and also splits them up per sub-module. The diff against privatemsg.pot is pretty much useless, though... :)
Comment #9
berdirUpdated the patch, will commit this soon.
I used --mode=multiple and all strings that occur in multiple modules are part of privatemsg.pot.
Comment #10
berdirCommited, needs to be done for 7.x too
Comment #11
berdirCommited to 7.x. This will need another update short before the 1.0 release but is fixed for now.
Comment #12
berdirUpdated to include the latest chance, the strings should now be fixed for the 1.0 release.
Note that this does also partly revert the change from http://drupal.org/cvs?commit=292344 since that commited merged all strings into a single file again.
I wil commit this to 6.x-1.x-dev now.
Comment #13
berdirA few more changes because of the paging issue. Committing this against 6.x-1.x-dev now. Fixes also a typo and double escapes in the german translation.
Comment #14
berdirI'm closing old translation related issues, translation should be handled on localize.drupal.org now.
Please see Maintainer News dec 7 2010 for more information:
A. If you are a translation maintainer: you've already been contacted, and
your team is in the process of moving from drupal.org to localize.drupal.org.
B. If you are a translator: stop working on .po files in CVS (either for
Drupal core or contrib), instead import existing .po files from CVS to
localize.drupal.org (if not already), remove the imported file from CVS and
work on localize.drupal.org from now on.
C. If you are a drupal.org project maintainer: do not accept .po files
anymore in your issue queues and remove your .pot files from CVS; tell people
to use localize.drupal.org.
Comment #17
avpadernoI am removing issue tags used from one to four issues. I apologize for bumping the issue.