Some error messages aren't logged

jmiccolis - April 27, 2009 - 19:34
Project:Salesforce
Version:6.x-2.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed
Description

The watchdog wrapper in the DrupalSalesforce object isn't properly passing error messages to the watchdog function. A very quick-fix style patch to this is attached. However, it looks like this call to watchdog is leftover from a 5.x upgrade as the strings that are passed to it are passed through t().

AttachmentSize
sf_fix_log.patch659 bytes

#1

Bevan - May 8, 2009 - 23:18
Status:active» needs review

Makes sense, though I hadn't noticed this bug. I (or someone other than the author) needs to test for it, then check the fix. Once RTBC I'll commit.

#2

Jonah Ellison - July 28, 2009 - 19:11
Priority:normal» critical
Status:needs review» reviewed & tested by the community

Verified and tested. Please implement this. It would have saved me a lot of time and headache if I was able to see what was wrong with my server without having to hack/debug this module.

#3

Bevan - July 31, 2009 - 03:17
Status:reviewed & tested by the community» fixed

Fixed in DRUPAL-6--2 by using watchdog according to Drupal 6 standards. See http://drupal.org/cvs?commit=245212

#4

Bevan - July 31, 2009 - 03:25

Removed

#5

Bevan - July 31, 2009 - 03:24
Status:fixed» active

Wrong node

#6

Bevan - July 31, 2009 - 03:24
Status:active» fixed

Still wrong node

#7

System Message - August 14, 2009 - 03:30
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.