It looks to me like private_file_download() should be removed from the Drupal 6 version of this module. It assumes that files are associated with nodes in the {files} table, but that's no longer the case in Drupal 6.

If I understand correctly, access to attached files are controlled by hook_file_download implementations in the modules that handle the files, which are often going to be the upload, filefield, and imagefield modules.

It doesn't look private_file_download() should interfere with other modules, but it'll spend time trying to load nodes with null nids. It was needed in Drupal 5 to control access to attached files, but I think this need has gone away with the way Drupal 6 handles files. Does this make sense to others?

Thanks!

Comments

adamps’s picture

Issue summary: View changes
Status: Active » Closed (outdated)

Tidying up ancient D6 support request.