Per discussions in the development list. IMO, changing a menu weight (or expansion) is not really grounds for locking out hook_menu_alter from being able to do what my module needs to do. I put this in as a feature request because chx says this is the way it is supposed to work.

CommentFileSizeAuthor
#8 menu.admin_.inc_.patch1.84 KBnancydru
#5 menu.admin_.inc_.patch1.82 KBnancydru
menu.admin_.inc_.patch963 bytesnancydru

Comments

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

BTW, this patch can be back ported to 6.x as-is. However, the damage to menu_links has already been done although an individual admin can easily undo it with "UPDATE `menu_links` SET customized = 0" (assuming there is no "real" customization in there).

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review
Issue tags: +DX (Developer Experience)

Well the patch needs a review.

chx’s picture

chx commented
Status: Needs review » Needs work
Issue tags: -DX (Developer Experience)

Nancy, thanks for the patch. I think it's going in a good direction but comments go above the code line not besides. You are using some strange quotes, just use plain apostrophe. Also please check menu_edit_item too. You can change weight there too.

chx’s picture

chx commented
Issue tags: +UX

Sorry, I have crossposted but this is indeed not developer experience. More like user experience.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Needs work » Needs review
StatusFileSize
new menu.admin_.inc_.patch1.82 KB

Status: Needs review » Needs work

The last submitted patch failed testing.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

I have no idea why it should fail; the patch was created by CVS from a HEAD checkout.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Needs work » Needs review
StatusFileSize
new menu.admin_.inc_.patch1.84 KB

Status: Needs review » Needs work

The last submitted patch failed testing.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Are the tests, by any chance, flawed in this respect?

deviantintegral’s picture

deviantintegral commented

It strikes me that modules/menu/menu.api.php should also be updated to contain documentation as to what constitutes a customized menu entry. The current docs make it seem like there are no restrictions, which I think caused much of the confusion in the first place.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

It should also mention the ramifications of being "customized" - and that pretty much means that hook_menu_alter can no longer be relied on to make menu changes.

Anonymous’s picture

Anonymous (not verified) commented

The tests didn't fail because it couldn't apply the patch, it failed during the 400+ tests it does for creating and deleting menu items.

Most of the API documentation resides in the body of the code. The API documentation that doesn't reside within the body of the code resides in one of the folders of http://cvs.drupal.org/viewvc.py/drupal/contributions/docs/developer/ so the proper way to change the documentation is to submit a patch.

Anonymous’s picture

Anonymous (not verified) commented

And you may need to modify the tests to fit the new functioning of the API.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

I have not gotten to where the tests make sense to me yet, so I can't do much about that.

themselves’s picture

themselves commented

Erm... Why doesn't hook_menu_alter change a customized menu item? That makes no sense at all. Drupal seems to be going out of its way to make life difficult for people who'd like to have dynamic menu titles. Surely it is quite reasonable to create a menu item with hook_menu and then want to change it later on with hook_menu_alter? Dynamic titles in hook_menu don't work (until you clear the cache), hook_menu_alter doesn't work if you've had the audacity to want to order your menu items... What happened to good ol' $may_cache from D5? That worked perfectly for this sort of situation!

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Thanks for reminding me about this one. Now that I understand a bit about the testing now, maybe I can make this pass.

chx’s picture

chx commented

What happened to this?

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

RealLife™ seems to have gotten in the way.

gagarine’s picture

gagarine commented
Issue summary: View changes
Issue tags: -UX +Usability

Usability is preferred over UX, D7UX, etc. See https://www.drupal.org/issue-tags/topic

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Assigned: nancydru » Unassigned

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.