This patch fixes the install file for the webfm_statistics table. You may have to manually delete the webfm_statistics entry from the system table for this to work (there was no uninstall function). I also changed the timestamp to standard unix timestamp. The date() formatting is my own preference.

NB: The repo isn't clear as to which version should be checked out. Easiest to stick to HEAD.

CommentFileSizeAuthor
webfm_statistics.patch4.17 KBrobmilne

Comments

robmilne’s picture

robmilne commented
Priority: Normal » Critical
Status: Active » Needs review
jadowd’s picture

jadowd commented
Assigned: Unassigned » jadowd
jadowd’s picture

jadowd commented
Assigned: jadowd » Unassigned

What was wrong with the install file?

jadowd’s picture

jadowd commented
Status: Needs review » Fixed

Got it. I have applied your patch, also, re manually deleting your system table entry, I don't recommend that. Disable the module and use the "Uninstall" feature.

Please test the new module and let me know that it is working? I haven't done this before and am not certain that I did it right.

Hope that helps.

Thanks,

robmilne’s picture

robmilne commented

Typo in webfm_statistics_schema ('i' was missing) prevented hook install from finding the schema. Also you also didn't include an uninstall hook so that the db can be cleaned up if the user wishes to remove the module. I took the liberty of making other changes too since the date didn't work.

jadowd’s picture

jadowd commented

got it. Thanks a lot! I have fixed a couple of l;inking bugs and applied your patch... should be up in less than 24 hrs.

Regards,

robmilne’s picture

robmilne commented

No problem. Thanks for extending the functionality of the webfm module and contributing to the Drupal community.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

clarkburbidge’s picture

clarkburbidge commented

This patch fixed the db install and date/time display issues. Thank you!