Hey. Great work on the module; it is really extensive. I just wanted to bring put a few points about namespaces:

* Module Namespace: Any sub-modules should be named with prefix of the core module. This is not required, documented, and CCK does not follow it, but it is bad practice, as WebChick has reinforced in IRC for me. Specifically you are using the "openlayers" module namespace, which is taken: http://drupal.org/project/openlayers

* Function Namespace: All functions within a module should be prefixed with the module name (not just hook implementations), and usually "private" functions are prefixed with an underscore (_)

I started this thread to get some documentation on this: http://groups.drupal.org/node/21725

Comments

zzolo’s picture

Status: Active » Closed (duplicate)

Damn, must have hit the button twice. See #446934: Namespaces