There are 2 discounts with weight: 0.
I guess they should be summarized.
But they are applied one by one.

For example:

Total price: 2190.
First 10% discount: -219.
Subtotal: 1971.
Second 10% discount: -197.
Order total: 1774.

I guess it should be:

Total price: 2190.
First 10% discount: -219.
Second 10% discount: -219.
Order total: 1752.(=2190-20%)

CommentFileSizeAuthor
#6 uc_discounts.zip10.92 KBryangroe

Comments

ryangroe’s picture

ryangroe commented

Ya, the behavior if they have the same weight is undefined. I like your suggestion but should we keep both discount descriptions in the review page?

ARray’s picture

ARray commented

but should we keep both discount descriptions in the review page?

yep.

ARray’s picture

ARray commented

still waiting for it :)

ARray’s picture

ARray commented
Priority: Normal » Critical

2ryangroe:
Will it be fixed?
I need two 5% discounts make 10% total discount.

ryangroe’s picture

ryangroe commented

I've been behind this month at my day job so I've fallen behind with this module too. I'm going to wrap up as many issues this weekend as I can and I will work on this one first.

ryangroe’s picture

ryangroe commented
StatusFileSize
new uc_discounts.zip10.92 KB

This is a bit awkward to implement so I applied this fix to "percent off" discounts only. However, I think that may be the only time this change could be applied. I've attached a patched version of uc_discounts.module. Please upgrade to beta 29 and try the attached file.

ryangroe’s picture

ryangroe commented
Status: Active » Needs review

I am going to incorporate this change into the next release. Please test it out on your site.

ryangroe’s picture

ryangroe commented

One small update, the discounts have to apply to exactly the same products (or both have to apply to all products). This change is part of beta 30.

ARray’s picture

ARray commented

it works. thank you!!!

ezra-g’s picture

ezra-g commented
Priority: Critical » Normal
Status: Needs review » Fixed

This was part of beta 29.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.