I noticed that theme's style.css file is not included in the help popup, but the theme's template.php file is active. So I have weird breadcrumbs now in the pupop window as I override the theme_breadcrumb()

Is there a reason why the style.css is not included in the popup? What is the correct way for theming the help window?

CommentFileSizeAuthor
help_popup.png8.9 KBpasqualle

Comments

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Active » Closed (works as designed)

The way AH currenly works, popups are built as a page with only the AH CSS included, printing the page on its own and returning NULL, instead of returning it as happens for a normal page.

That way core won't format it as a normal page, and AH gets to build the popup "page-equivalent" template itself, in advanced-help-popup.tpl.php. Now, this includes the CSS files, but the standard preprocess in AH, template_preprocess_advanced_help_popup($variables) removes them as you can see on lines 881-887.

  // Remove theme css.
  foreach ($css as $media => $types) {
    if (isset($css[$media]['theme'])) {
      $css[$media]['theme'] = array();
    }
  }

Which means you can workaround this removal by creating a module of your own, which will copy the theme CSS in its own preprocess, and inject them again, as AH does not remove module CSS, only theme CSS.

I have not found an issue where this specific design choice was considered, but I suspect this is because popups are intended to be handled differently from normal pages, as they don't have as much screen real estate, have less window decorations, and so on, so it makes /some/ sense to remove the theme CSS, which is liable to be designed only for full pages.