Start/End Date/Time editing in Events is very confusing

jurgenhaas - April 28, 2009 - 16:20
Project:Event
Version:6.x-2.x-dev
Component:User interface
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review
Description

We are using Deupal 6.10 and the latest Events release. When creating or editing an event the section to input start or end date and time is displayed in a very confusing format:

[day][minute][hour][month][year]

We haven't found a way yet to modify that and need some help as our authors are having troubnle entering proper dates. The fields are not labeled either, si it's always trial and error to input the correct date and time.

#1

Frank Ralf - April 29, 2009 - 11:45

I can confirm this bug with Drupal 6.10, Event 6.x-2.x-dev (2009-Mar-16), see screenshot. The theme is out of the box Garland .

Frank

AttachmentSize
Create_Event_Time.png 9.77 KB

#2

killes@www.drop.org - June 28, 2009 - 16:46

event.module uses date_format_short for formatting the select box.

on admin/settings/date-time, which option did you chose for "short time format"?

If I use "28.06.2009 18:44" then I get the boxes in this order.

#3

killes@www.drop.org - June 28, 2009 - 16:46
Status:active» postponed (maintainer needs more info)

changing status

#4

jurgenhaas - June 29, 2009 - 05:41

Thanks for your response.

I had "2009-06-29 7:45" as the date-time-format which resulted in the reported field sequence.

Now I changed it to "29.06.2009 7:45" and the fields in the event edit are in the same and expected order as the date-time-format.

Thanks, for me the issue is solved but it feels as if in general this is not quite solved for every format.

#5

killes@www.drop.org - June 29, 2009 - 07:57

I have now set my short date format to what you describe and it works as expected for me.

Not sure what to do about this.

#6

Frank Ralf - June 29, 2009 - 09:21

I use the user defined date format "d.m.Y" and the input fields get still mangled (see screenshots, the date is 1 July 2009, 19:30 h). Pre-defined formats seem to work, though.

AttachmentSize
Event_input_fields.png 15.36 KB
Date_settings.png 36.54 KB

#7

jurgenhaas - June 29, 2009 - 11:24

Yes, I can confirm that it must have to do with custom date formats. All others I've tried seem to work correctly.

And I get the same wrong event_input_fields as displayed in #6 attachment #1 when using custom date format.

#8

killes@www.drop.org - June 30, 2009 - 06:26
Status:postponed (maintainer needs more info)» active

I think the problem is that you did not specify hour and minutes in your format. THis confuses my "algorithm". I will try to fix this.

#9

Frank Ralf - June 30, 2009 - 06:45

Thanks!

#10

killes@www.drop.org - June 30, 2009 - 06:48

After thinking about this a bit: Does that mean you never use the hour:minute fields in the event form? If yes, I could just omit them.

#11

Frank Ralf - June 30, 2009 - 07:10

No, not at all! I certainly need hour/minutes settings for events. I only set the short date format to not using them because Drupal also uses the short date format for the publishing date of nodes. _There_ I don't want hours/minutes.

So it comes down to the short date format being used as default format at different places in a Drupal installation. Preferably the Event module wouldn't rely on such a site wide setting.

Thanks for your efforts!
Frank

#12

killes@www.drop.org - June 30, 2009 - 07:13
Status:active» needs review

Here is a patch that would not show the hour and minute fields if they are not in the format.

The time will be saved as 12:00 in the database.

Please try it.

AttachmentSize
event_no_time.patch 2.23 KB

#13

killes@www.drop.org - June 30, 2009 - 07:29

ah, darn, I hadn't read your answer before rolling this nice patch. :p

I am not sure about not using a site-wide setting. In my opinion, dates and times (or other similar things like usernames) should be displayed in the same way everywhere on a site. Hence my attempt to use this format to determine the order of the input boxes.

However, see the issue at #395952: Date display on event node page where I will allow users to chose which time format to chose.

#14

killes@www.drop.org - July 4, 2009 - 21:57

Actually, I've reconsidered what I wrote above. I guess it is the cleanest solution to introduce an event specific input format _and_ apply this patch.

 
 

Drupal is a registered trademark of Dries Buytaert.