I have a CCK field that has an apostrophe in it and in the facet block I get Printable PDF& # 039;s (3) (spacing added to prevent re-encoding here)

Pwolanin mentioned we should try not using 'safe' values in apachesolr.index.inc line 127 since strip_tags is used afterwards.

CommentFileSizeAuthor
#7 cck-value-447622-7.patch3.18 KBpwolanin
#6 cck-value-447622-6.patch2.51 KBpwolanin
#5 cck-value-447622-5.patch2.51 KBpwolanin
#3 cck-value-447622-3.patch2.51 KBpwolanin
#2 cck-value-447622-2.patch1.81 KBpwolanin
#1 cck-value-447622-1.patch1.23 KBpwolanin

Comments

pwolanin’s picture

pwolanin commented
Status: Active » Needs review
StatusFileSize
new cck-value-447622-1.patch1.23 KB

still seems to be a problem for CCK facets with &

pwolanin’s picture

pwolanin commented
StatusFileSize
new cck-value-447622-2.patch1.81 KB

ok, with some extra decoding thrown in per: #420290: document preparation runs words together

pwolanin’s picture

pwolanin commented
StatusFileSize
new cck-value-447622-3.patch2.51 KB

helpful to get the body too

pwolanin’s picture

pwolanin commented

Two tests:

A CCK text field radios w/ allowed values such as:

PDF's
That’s it
Abc Def

and
in the body text 

German Umlauts like in Hängebrücke

Without converting ä and ü into "ä" and "ü" a search for "Hängebrücke" should have no result.

pwolanin’s picture

pwolanin commented
StatusFileSize
new cck-value-447622-5.patch2.51 KB

or this

pwolanin’s picture

pwolanin commented
StatusFileSize
new cck-value-447622-6.patch2.51 KB

#3 is safer, I think.

pwolanin’s picture

pwolanin commented
StatusFileSize
new cck-value-447622-7.patch3.18 KB

opps missed query class change

pwolanin’s picture

pwolanin commented
Status: Needs review » Fixed

committed to 6.x

pwolanin’s picture

pwolanin commented
Status: Fixed » Closed (fixed)