Webform mail settings not being saved on node form (2.x)

Hi,
I also experience this issue, but not always.
I found out, that it happens "only" when the field Description is filled in.

#471990: Preview reverts email settings to default values. more accurately diagnoses the problem I think, basically clicking "Preview" resets the values to the defaults. I've confirmed this is still a problem in the 2.9 version, though 3.x is not affected because it has moved the e-mail settings off of the node form.

I can confirm that removing content from Meta tags "Description" field seems to "fix" the problem.
This has been driving me nuts forever!

I have installed the 3.0-beta5 version this morning and find that none of the email settings are being saved. I enter an Email to Addess and click Add, complete the Email Subject, From, Name fields and save. I receive an Email Settings Updated message, but it has not. Below that message, it continues to say, Currently Not Sending Emails are being sent or such.

Here is the page in question -

http://www.interaction.org/node/1478/webform/emails

(The actual form page - http://www.interaction.org/temp-working-groups-page - was first designed with basic HTML mailform fields, so ignore those for now. The WEBFORM MODULE is at the very bottom. However... if you can help also tell us how to layout the Webform fields like we did the HTML mailforms... it would be awesome!)

If you cannot access these pages, please see the attached screenshot. Let me know if you can't access the page and I'll try to tweak the visibility settings.

Tony

tfleming: Please open a new issue for your request, it sounds like it's a completely different problem that affects only the 3.x version, as opposed to this issue that is specifically a 2.x version problem.

Done. http://drupal.org/node/776870

I can confirm that removing content from Meta tags "Description" field seems to "fix" the problem - partially. Not only are the three email fields affected, but also the conditional email recipients checkboxes. I can not find a way to get these to save (removing content from the meta tags description field allows the other 3 fields to save though)

EDIT: Actually, I take it back. I can't get these fields to save what ever I try.

I've sifted through the module, and found that the issue is with webform.module on line 479 where it is seeing what operation the node form is currently in.

This is all good, unless you aren't clicking submit. Which can presumably happen when clicking preview, or if you've changed the names of your submit button to something else (in my case it's called Publish - which might be another module that is in place, I haven't delved into that yet)

So, the function webform_submit was never getting called.

Anyway, I'm changing
if (isset($node->op) && $node->op == $node->submit) {

to

if (isset($node->op) && ($node->op == $node->submit || $node->op == $node->publish)) {

but I can't see why it matters if this is done on all ops, ie, all the time should be fine? so:

if (isset($node->op)) {

If anyone knows why this last one will fail, please respond, otherwise I think we can roll a patch for this.

Dare I suggest it, but Webform 3.x's rewritten node handling avoids this problem entirely. The we deprecate the 2.x version the better...

However, I can't see any problem with the approach you've suggested, since $node->op is only set when saving through the node form. It might be worth looking into the CVS history to see why the $node->op == $node->submit part was added.

Looks like that line was added all at once during the very initial Drupal 6 port. My guess is your approach shouldn't cause any adverse effects.

Initial commit of that line: http://drupalcode.org/viewvc/drupal/contributions/modules/webform/webfor...

Clearly upgrading is a better option, but for the site in question I can't right now. Here is a patch.

Edit - text removed. No longer relevant.

RichieRich: Could you be more specific about which form you're submitting that causes the e-mails not to be sent/saved? Perhaps yours is a different issue, it just sounded similar to this one. Please reopen your other issue if it seems that they are indeed separate.

By "which form" I mean is it the form for editing the node (that's what this issue is for), or it is the form that the end-user fills out when viewing the node?

Edit - text removed. No longer relevant.

I've attached another patch, based on the one posted by mrfelton, in case anyone else is stuck on version 2.x and has added some cck fields to their webform.

This patch ensures that
a) the email fields are saved correctly.
b) added cck fields are saved correctly.

I won't be making any more 2.x releases.