Permissions are backwards

bkat - April 29, 2009 - 01:40
Project:User mailman register
Version:6.x-2.0-alpha1
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

We're integrating some mailman lists through our site and we want to them to be admin-centric. I found out that the permissions seem to be backwards. For example, userX has permission to administer user mailman settings and normal users don't have access.

userX's roles allow her to subscribe to list1,list2,list3
userY's roles allow her to subscrible to list1,list2,list4

when userX goes to admin subscriptions for userY, the lists that are presented are those that userX can subscribe not those that userY can subscribe.

This appears to be easily fixed in _user_mailman_register_form() by passing $account to _user_mailman_register_allowed_list().

Patch included.

AttachmentSize
user_mailman_register.module.patch234 bytes

#1

samuelet - April 29, 2009 - 07:20
Version:6.x-1.3» 6.x-2.x-dev
Status:active» fixed

Thanks but the 6.x.1 release is not supported anymore.
6.x.2 release should already fix it. If it does not, feel free to reopen this issue.

#2

bkat - April 29, 2009 - 07:29

How about changing the project page so that it doesn't say that 6.x.1-3 is the recommended version?

#3

bkat - April 29, 2009 - 07:37
Version:6.x-2.x-dev» 6.x-2.0-alpha1
Status:fixed» active

Exact same problem occurs in 6.x.2,0-alpha1. Exact same change fixes it.

#4

samuelet - April 29, 2009 - 07:58

6.x.1-3 is still the more reccomended version, because others are under heavy development (this is how drupal suggests).
Please, test the 6.x.2 release not the alpha one, bug fixes and new features are implemented first of all there. You can also check its code before installing it in the CVS source.

#5

bkat - April 29, 2009 - 08:18

I don't see a 6.x.2 release on the project page, Just the 6.x-2.0-alpha1 and the -dev version. I

#6

samuelet - April 29, 2009 - 08:26

Sorry, i just meant the 6.x-2.x-dev release.

#7

bkat - April 29, 2009 - 19:20
Status:active» fixed

I looked in CVS and the same change I made is there so its safe to call this fixed.

#8

System Message - May 13, 2009 - 19:30
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.