Cache menu items

kingandy - April 29, 2009 - 16:20
Project:SagePay (former Protx) Direct Payment Gateway for Ubercart
Version:5.x-1.3
Component:Code
Category:task
Priority:minor
Assigned:Unassigned
Status:won't fix
Description

Is there a reason the 3DSecure menu items are all in the !$may_cache clause of the hook_menu? These menu items will be declared every time a page is loaded. Probably not a massive performance hit, but since there's nothing dynamic about them it would be better for them to be cached.

Find attached a patch that adds a $may_cache clause and puts the menu items inside it, rolled against the current recommended release (5.x-1.3). I've left the drupal_add_css in the !$may_cache clause (natch).

AttachmentSize
protx_cachemenu.patch2.41 KB

#1

kingandy - April 29, 2009 - 16:28
Priority:normal» minor

#2

hanoii - May 6, 2009 - 15:13
Status:needs review» won't fix

This was already fixed on the -dev version of the module. I will be releasing a new version soon as I took over the maintenance of the module.

 
 

Drupal is a registered trademark of Dries Buytaert.