Posted by kingandy on April 29, 2009 at 4:20pm
Jump to:
| Project: | Sage Pay Go Direct Payment Gateway for Ubercart |
| Version: | 5.x-1.3 |
| Component: | Code |
| Category: | task |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | closed (won't fix) |
Issue Summary
Is there a reason the 3DSecure menu items are all in the !$may_cache clause of the hook_menu? These menu items will be declared every time a page is loaded. Probably not a massive performance hit, but since there's nothing dynamic about them it would be better for them to be cached.
Find attached a patch that adds a $may_cache clause and puts the menu items inside it, rolled against the current recommended release (5.x-1.3). I've left the drupal_add_css in the !$may_cache clause (natch).
| Attachment | Size |
|---|---|
| protx_cachemenu.patch | 2.41 KB |
Comments
#1
#2
This was already fixed on the -dev version of the module. I will be releasing a new version soon as I took over the maintenance of the module.