Search module code documentation is outdated

That seems to cover it.

Good call on removing "hook_search_item". I've searched the API and the code extensively and found that not only is this hook not documented, it also isn't called. That line is the only occurrence of "search_item" anywhere in Drupal 7. :)

Committed to CVS HEAD. Thanks!

hook_search_item didn't exist in Drupal 6 either.

*Or* in Drupal 5.

*Or* in Drupal 4.7.

For giggles, I grepped through all our major releases and head to go all the way back to Drupal 4.6 to find module_invoke($type, 'search_item');. Talk about a blast from the past. :)

This still needs to be fixed in Drupal 6:
http://api.drupal.org/api/group/search/6

Please check this over. I think some of the changes in this patch are D6->D7 patches. For instance, in D6 we still use hook_nodeapi, where in D7 this was changed to a variety of different hooks.

Oh, I changed the $op parameters into functions (like D7), but should have left them alone. The D6 issue is on: removing "hook_search_item"
and
"implement nodeapi('update index') and nodeapi('search result')"
should perhaps be
"implement hook_nodeapi('update index') and hook_nodeapi('search result')"?
Am I close?

Yes, that's what needs to be done.

Great. *Note -I didn't want to wrap the functions on 2 lines, thus the shorter 'Specifically...' line. Hope that's acceptable.

Looks good, thanks.

Oops, spoke to soon - patch needs to be rerolled from Drupal root

That's better, thanks!

Thanks, committed.