The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.The following line is in node.admin.inc:
$sort = tablesort_sql($header, '', 'n.changed DESC');
tablesort_sql() only takes two arguments, so the third argument was ignored. Furthermore, the table already sorts by default due to the table header including:
$header[] = array('data' => t('Updated'), 'field' => 'n.changed', 'sort' => 'desc');
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | node-admin-remove-tabesort-sql-argument-rev3.patch | 3.25 KB | berdir |
| #3 | node-admin-remove-tabesort-sql-argument-rev2.patch | 3.9 KB | brianV |
| node-admin-remove-tabesort-sql-argument.patch | 935 bytes | brianV |
Comments
Comment #1
berdirHum, seems that I forgot to convert this to DBTNG, no idea why...
This needs to be converted to DBTNG anyway. This needs to be a dynamic query with Extenders and node_access tag.
Comment #2
berdirAnother possibility to resolve this.. #450666: Filter DB Extender
Comment #3
brianV commentedJust posting an in-progress patch here for safekeeping, as I need to use my D7 cvs for some other work. Leaving at CNW, since the patch is not complete yet.
Berdir, feel free to take this one over, since you are much more familiar with DBTNG than I am.
Comment #4
brianV commentedComment #5
brianV commentedComment #6
berdirRe-rolled the patch..
Comment #8
brianV commentedSetting to 'needs review' - testbot was broken.
Comment #10
berdirTestbot, I don't believe you :)
Comment #12
andypostBot was broken
Comment #13
andypostComment #14
brianV commentedJust reviewing this again. Works, and passes testbot. RTBC.
Comment #15
webchickCommitted to HEAD, thanks!