Inline diff doesn't seem to work

Yeah there is no documentation of the new features, so initially it throws you for a loop. The new inline functionality can be harnessed via a button entitled "Highlight changes" under the view tab of the node. After punching it you get a drop down selection to checkout inline diffs; different from what I expected. Nevertheless very welcomed features!

I just updated to latest dev and it worked for me. I saw it on OpenAtrium's home and really liked it!

I see the "highlight changes" button, but not the results. I see only legend with coloured background, but no changes (differences in background colour) in the text. Neither the changed parts of text have any additional class related to diff module. It is the same for the last stable and last -dev version. Thank you in advance for help.

I am not seeing the highlighted text as well.

I'm seeing the link to show inline diffs but when I click it differences aren't highlighted, if I use Show Diffs from the Revisions tab the differences are displayed correctly.

I tested this with alpha 3 and dev releases

I've found what I believe to be the cause of this issue but I'm not entirely sure how to fix it.

For starters will need to change

$old = db_fetch_object(db_query("SELECT body, format FROM {node_revisions} WHERE nid = %d AND vid = %d", $node->nid, $target_vid));

to

$old = node_load($node->nid, $target_vid, TRUE);

So that cck fields will be available to the preg_split code.

But I have no idea how to refactor the preg_split code to also act against cck fields and then reassemble for $output...

diff.pages.inc line 388

/**
 * Generate a rendered inline diff of the node body.
 */
function diff_inline_diff($node, $target_vid) {
  module_load_include('php', 'diff', 'DiffEngine');
  $new = drupal_clone($node);

  // We could use a node_load() / node_prepare() combo here but for now
  // we would rather save queries...
  $old = db_fetch_object(db_query("SELECT body, format FROM {node_revisions} WHERE nid = %d AND vid = %d", $node->nid, $target_vid));
  $old->body = check_markup($old->body, $old->format, FALSE);

  $new = preg_split('/(<[^>]+?>| )/', $new->body, -1, PREG_SPLIT_DELIM_CAPTURE);
  $old = preg_split('/(<[^>]+?>| )/', $old->body, -1, PREG_SPLIT_DELIM_CAPTURE);

  $diff = new Diff($old, $new);
  $diff->edits = _diff_inline_process_edits($diff->edits);

  // Assemble highlighted output
  $output = '';
  foreach ($diff->edits as $chunk) {
    switch ($chunk->type) {
      case 'copy':
        $output .= implode("", $chunk->closing);
        break;
      case 'delete':
        foreach ($chunk->orig as $i => $piece) {
          if (strpos($piece, '<') === 0 && substr($piece, strlen($piece) - 1) === '>') {
            $output .= $piece;
          }
          else {
            $output .= theme('diff_inline_chunk', $piece, $chunk->type);
          }
        }
        break;
      default:
        $chunk->closing = _diff_inline_process_chunk($chunk->closing);

        foreach ($chunk->closing as $i => $piece) {
          if ($piece === ' ' || (strpos($piece, '<') === 0 && substr($piece, strlen($piece) - 1) === '>')) {
            $output .= $piece;
          }
          else {
            $output .= theme('diff_inline_chunk', $piece, $chunk->type);
          }
        }
        break;
    }
  }
  return $output;
}

Patch attached

This patch doesnt help.

But I already have applied
http://drupal.org/node/639320 Patch #24
and http://drupal.org/node/372957 Patch #8

With the help of these I was able to see the "Highlight changes" button (sometimes). Sometimes the changes were already colored, but I dont see the button. Sometimes I see the button, but no colors. Nevertheless the above mentioned patches do fix the problem "partially".

Patch #11 doesnt improve this. :( [Without the patches mentioned above I cant get diff running with php5.3 :/ ]

I found yesterday my patch at #12 only works if your template renders the node->content , using a custom tpl or contemplate will likely stop it from displaying correctly.

I'm not using php 5.3 here so am unable to test my changes to see if 5.3 causes additional issues

Thanks, committed: http://drupal.org/cvs?commit=405702

This patch seems to almost perfectly work for me. I have php 5.2x installed. The only issue I note is that on nodes that have fieldsets collapsed, the collapsed fieldsets do not render the inline diff. If I open the fieldsets, the diff works perfectly...

still seeing revisions in side by side columns and no "Highlight changes" button on latest dev version even on default Garland theme..

running PHP 5.2

I also don't see "Highlight changes" anywhere. I tried 6.x-2.3 and the latest dev version. running on php5.3

Regarding #18 / #19

This is only present in the block "Inline differences", so enable that and you should see the button.

Re: #20 -- This button is now hidden by default, right? It should load automatically?