Please, I have a couple of requests, in the hope to make the settings panel of this module easier to navigate/understand.

  1. move the huge description in top of the settings panel to hook_help. Maybe a small description would be enough, that could even include a link to the help page.
  2. Set some fieldsets as collapsed by default. For instance: Group attributes, Custom Channels (not everyone using GoogleAds use channels) or Revenue sharing options (same as with channels).

Thanks

CommentFileSizeAuthor
#2 adsense.module.patch2.6 KBmarkus_petrux

Comments

markus_petrux’s picture

markus_petrux commented

Sorry, now that I read myself, it seems to me that 1) was kind of confusing. I believe that sometimes I can express my self better using code. I mean, that you could replace this (in function adsense_help):

    case 'admin/settings/adsense':

With the following:

    case 'admin/settings/adsense':
      $output = t('Please, click <a href="%moreinfo">here</a> to get more information about the Google AdSense module', array('%moreinfo' => url('admin/help/adsense')));
      break;
    case 'admin/help#adsense':

So, in the settings page only a little message is shown, that points to the help page, with all the information.

markus_petrux’s picture

markus_petrux commented
Status: Active » Needs review
StatusFileSize
new adsense.module.patch2.6 KB

Here's a patch. I believe, this way, the settings is much easier.

kbahey’s picture

kbahey commented
Assigned: Unassigned » kbahey
Status: Needs review » Fixed

Good idea.

Fixed.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)