I'm not sure if this is site specific or a problem with the theme yet.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | comment.preview.pic_0.patch | 970 bytes | RobRoy |
| #2 | comment.preview.pic.patch | 1.01 KB | RobRoy |
I'm not sure if this is site specific or a problem with the theme yet.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | comment.preview.pic_0.patch | 970 bytes | RobRoy |
| #2 | comment.preview.pic.patch | 1.01 KB | RobRoy |
Comments
Comment #1
smichel commentedI just found this one, too. In the comment module, we have this code:
By testing, I see that when previewing a comment, we're in the "else" part of this test, and $comment is being set in
if ($edit['id']){.I'll keep poking at it and see if I can figure a good way to fix it. I haven't dug into the comment module too closely yet, mostly to theme it.
Comment #2
RobRoy commentedLooks like
1. theme_comment_preview() doesn't even seem to be used. Now we are building a preview using FAPI and $output .= theme('comment_view', $comment); The problem is that $comment->picture is not getting loaded in the preview.
2. Between theme_comment_view(), phptemplate/comment.tpl.php and bluemarine/comment.tpl.php there are quite a few inconsistencies including omission of $picture and different CSS class names for the submitted by div.
But #2 is really non-critical so this patch just includes $comment->picture in the preview and let's PHPTemplate deal with the rest.
Comment #3
RobRoy commentedI hate extra spaces.
Comment #4
drummI think theme_comment_preview() should be left in and used.
Comment #5
RobRoy commentedtheme_comment_preview() wasn't being used in HEAD, so are you suggesting I modify the code to use it again? What about an optional $preview = FALSE arg in theme_comment_view()? I'm fine with putting it back in there, just want to make sure that's the consensus.
Comment #6
ricabrantes commentedThis patch is applies?? Feature requests go to the current development version...
Comment #7
dave reidComment #8
naxoc commentedDuplicate of #1058564: User picture does not appear in comment preview.