Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Nodes per page is ignored in the admin modr8 page. This patch fixes this issue.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | cleanup-modr8-450142-8-D5.patch | 1.86 KB | pwolanin |
| #6 | cleanup-modr8-450142-6-D6.patch | 2.55 KB | pwolanin |
| modr8_node_count.patch | 978 bytes | marcingy |
Comments
Comment #1
marcingy commentedComment #2
pwolanin commentedComment #3
marcingy commentedHmm as there is a setting on the admin page but that setting is ignored I would say that is an omisison and hence a bug, otherwise why is the option provided?
Comment #4
pwolanin commentedoh, indeed - sorry.
Comment #5
Avatar commentedIs this about that the mod isn't working at all? I mean all posts get published immediately whichever setting is there in the module admin page!!
If so, I still have a problem since I don't understand anything about coding and I don't know what to do with these lines of code in the patch above. Can someone help?
Comment #6
pwolanin commented@Avatar - whether or not nodes are published must be set for each node type. This module only adds the option to make them published upon approval if they were initially unpublished. Given that > 1000 sites are using the D6 module, I don't think it's fundamentally broken: http://drupal.org/project/usage/modr8
Actually I this patch touches code that's so stupid that I surely hope it's from before I took over the module. There is no reason to do 2x pager_queries. Attached patch cleans up a little more generally.
Comment #7
pwolanin commentedcommitted to to 6.x (HEAD) needs 5.x backport.
Comment #8
pwolanin commentedHuh, apparently that bad code actually came in the D6 upgrade - here's some D5 cleanup.
Comment #9
pwolanin commentedcommitted to D5 also