Closed (fixed)
Project:
Chrono
Version:
6.x-1.0-beta2
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
30 Apr 2009 at 22:58 UTC
Updated:
27 Dec 2010 at 17:29 UTC
Jump to comment: Most recent file
Comments
Comment #1
BaronVonInternet commentedThere are just a few simple issues that prevent this theme from being valid xhtml.
One already had a patch written at http://drupal.org/node/630668
My attached patch (my first patch, works for me, but beware in case I've done something wrong) includes that fix and also fixes the following errors:
1) In page.tpl.php
<html>should be:
<html xmlns="http://www.w3.org/1999/xhtml">2) In page.tpl.php
should be:
3) In page.tpl.php, line 16:
should be:
which also requires the following changes in styles.css, line 146:
div#homelink h1 {div#homelink h1 a {It changes the linked area to the site name rather than the whole colored area, but it seems to be a bug fix since the original version causes the linked area (showing hand icon) to extend off the right edge of the page.
4) In page.tpl.php
should be:
Comment #2
eigentor commentedThis is fixed in Head now.
Took me quite a while :D.
Going to push a new release soon with corrections.
For the link in the header h1: I put the link just around the text inside the h1, so it does not extend to far and should be valid. My DTD was crap, I changed it to a correct one. This should also correct the collision in Encoding, only UTF 8 is used now. Threw the target="_blank" out in the footer, so this should be alid also.
Ran a validation check and it revealed no errors.