Closed (fixed)
Project:
Table Wizard
Version:
6.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
30 Apr 2009 at 23:03 UTC
Updated:
29 May 2009 at 17:10 UTC
Jump to comment: Most recent file
keyword "connection" needs to be protected in sql query otherwise it causes sql errors (at least with MySQL 5.0.32 here). See attached patch...
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | tw-ticks.patch | 762 bytes | robertdouglass |
| #3 | backticks.patch | 7.87 KB | robertdouglass |
| #1 | connection.patch | 5.4 KB | mathieu |
| connection.patch | 3.62 KB | mathieu |
Comments
Comment #1
mathieu commentedForgot a few, new patch.
Comment #2
robertdouglass commentedYes, and this has to be extended to code like this:
It can happen that the $tablename is also a reserved word. For example, I ran into:
SELECT MIN(blah) FROM grant;Comment #3
robertdouglass commentedRerolled and added backticks for issue in #2. Agree that this is a critical issue.
Comment #4
mikeryanIt's just too gross to call tw_quote_column() on all those queries... I'm going to rename the field (say, to dbconnection), the code will be much cleaner.
Comment #5
mikeryanOK, I've committed fixes:
Thanks!
Comment #6
robertdouglass commentedHere's another place.
Comment #7
mikeryanCommitted, thanks!