Download & Extend
Issues

Upgrade instructions recommend enabling stark in D6

Posted by catch on May 1, 2009 at 11:26am
Project:Drupal core
Version:7.x-dev
Component:documentation
Category:bug report
Priority:minor
Assigned:Unassigned
Status:closed (fixed)
Issue tags:Quick fix

Issue Summary

Sun reminded me that since Drupal 6 we've run updates for disabled modules, however we didn't update the documentation.

4. If using a custom or contributed theme, switch
to a core theme, such as Garland or Bluemarine.

5. Disable all custom and contributed modules.

Is there any other reason to disable contrib modules? If not we should remove it. I think we should also improve the distinction between minor and major upgrades, but that's out of scope here.

Login or register to post comments

Comments

#1

Posted by AmrMostafa on May 13, 2009 at 3:25pm

Thanks for submitting this, I need to keep this on my watch list, definitely very important, but I gotta run now

#2

Posted by catch on May 13, 2009 at 5:20pm

I actually found a reason to disable contrib modules yesterday - I've been needing to run dummy d6 and d7 updates - both have devel module installed (and enabled in D6). In devel, on update.php it tries to call user_access() - but user_access() doesn't work because user_role_permissions has been renamed.

#3

Posted by xmacinfo on December 31, 2009 at 5:41am

Mentioned this issue in the D6 to D7 upgrade meta issue #563106: Cannot upgrade from Drupal 6 to Drupal 7 - meta issue.

Also, does it qualify as critical?

#4

Posted by catch on December 31, 2009 at 2:00am

I think we need to determine what the current best practice is and have this reflected in the documentation, but that's probably not critical.

However the instructions currently recommend switching to Stark before you upgrade. Except for the fact that there's no Stark theme in D6, whoops. That's trivial to fix, but we can't ship with it, so leaving priority unchanged for now.

#5

Posted by catch on December 31, 2009 at 3:58am
Title:Upgrade instructions are out of date» Upgrade instructions recommend enabling stark in D6

#6

Posted by psynaptic on December 31, 2009 at 10:46am

I have never switched themes or disabled any modules when doing an upgrade. Maybe I'm just extremely lucky but I have never had a problem.

#7

Posted by catch on January 23, 2010 at 2:22pm

Maybe a tag will help this one line trivial patch get written...

#8

Posted by mcrittenden on January 27, 2010 at 10:00pm
Status:active» needs review

Patch attached.

AttachmentSizeStatusTest resultOperations
upgrade.patch776 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 17,378 pass(es).View details

#9

Posted by catch on January 27, 2010 at 11:03pm
Status:needs review» reviewed & tested by the community

#10

Posted by webchick on January 28, 2010 at 7:09am
Priority:critical» minor
Status:reviewed & tested by the community» fixed

Oopsie. :) Committed to HEAD.

Guys, let's please watch the definition of 'critical', ok? :P Confusing upgrade instructions have been a 'feature' since Drupal 1. ;)

#11

Posted by System Message on February 11, 2010 at 7:10am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.