Reported by scubasmurf - April 22, 2009 - 08:05

Anyway, to make this spot on for my needs, is there any chance that the roles that appear under "Restrict access to certain Roles" can be pre restricted by content type as a Site configuration setting and also appear with default settings by content type? Alternativly force the roles that are selected under "Restrict access to certain Roles" by content type.

CommentFileSizeAuthor
#5 signup_restrict_by_role-defaults-per-type-450634-5.patch15.59 KBscottrigby
#4 signup_restrict_by_role-defaults-per-type-450634-4.patch15.59 KBscottrigby

Comments

deanflory’s picture

deanflory commented

I'm guessing there won't be any update to this module, but I'd like to see this functionality as well. It's a little annoying to have to click a bunch of checkboxes every single time.

scottrigby’s picture

scottrigby
he/him
Primary language English
Location Brooklyn, NY
commented
Title: Restrict access to certain roles » Defaults per type

Changing title for clarity

ebeyrent’s picture

ebeyrent commented

Patches are welcome!

scottrigby’s picture

scottrigby
he/him
Primary language English
Location Brooklyn, NY
commented
Assigned: ebeyrent » scottrigby
Status: Active » Needs review
StatusFileSize
new signup_restrict_by_role-defaults-per-type-450634-4.patch15.59 KB

@ebeyrent

Here's a patch that addresses this issue. It's patched against master (until #1329646: Update 6.x-1.x branch (Signup Restrict by Role) is merged).

This also includes the code cleanup patch in #1329648-4: Coding standards (Signup Restrict by Role) (cause it would be a pain to work on this without that patch), but it's properly git-formatted so you should be able to apply this and keep them as separate commits for d.o.

Note: since this issue required a lot of re-factoring, part of this also happened to fix #1039626: Adds signup restrict form to non-signup enable nodes.

scottrigby’s picture

scottrigby
he/him
Primary language English
Location Brooklyn, NY
commented
StatusFileSize
new signup_restrict_by_role-defaults-per-type-450634-5.patch15.59 KB

whoops typo. Updated patch attached

-      return array('signup_restrict', $signup_restrict);
+      return array('signup_restrict' => $signup_restrict);
scottrigby’s picture

scottrigby
he/him
Primary language English
Location Brooklyn, NY
commented
Status: Needs review » Fixed

Committed:
http://drupalcode.org/project/signup_restrict_by_role.git/commit/a585b25...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.