Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.If you're using the latest jQueryUI 1.7.1 with jquery_ui module and leaving drupal to do it's normal css aggregation you'll find the supplied css makes a bit of a mess of the conversion widget, some judicious commenting out lets the base jQueryUI theme do it's job without interference, and allows any custom themes generated using the jQueryUI themeroller to work too.
Attached is a diff with conflicting styles commented out in the money_conversion_dialog.css file.
I think this modules widget will need reworking if there's jquery_ui 2.x branch as per discussion at http://drupal.org/node/362509 so it works better with themes installed as per http://drupal.org/node/388384
For now I'll leave this issue as a placeholder in case someone else hits the problem, but I'd like to provide a patch once the jquery_ui and jquery_update modules have releases working with jQuery 1.7.1
| Comment | File | Size | Author |
|---|---|---|---|
| money_conversion_commented_out.diff | 726 bytes | adrinux |
Comments
Comment #1
markus_petrux commentedI'm using latest jquery update with jQuery 1.3.2, and jquery_ui with jQuery UI 1.7.1 on my development environment, and money conversion dialog seems to work well, not disturbing any other implementation of jQuery UI Dialog plugin installed on the same system, as I'm using the dialogClass parameter in ui.dialog to wrap all related CSS class.
Do you mean jquery_ui module will provide a central location to install and manage jQuery UI themes? So then, any module using jQuery does not need to provide specific classes for jQuery UI stuff?
But, what if I prefer my implementation of jQuery UI stuff uses its own set of CSS classes? Isn't enough using the dialogClass parameter of jQuery plugins? Where's the problem with that?
Sorry, I haven't been following the discussions you've mentioned.
Comment #2
markus_petrux commentedOk, now I've been reading those issues a little. But there's only patches, no stable feature yet implemented so that sites can choose which jQuery UI themes they wish, how to override them at Drupal theme level, etc.
On the other hand, the implementation I did here does not conflict with any other CSS because all selectors are wrapped by dialogClass owned by this module that's prefixed with module name, so it should be unique enough to not conflict with any other CSS on the site. And this approach allows sites to override CSS classes at Drupal theme level. Please, see the .css and .js files provided by this module and look at how the CSS class "money-conversion-wrapper" is used.
So I would say implementation here is ok and I'll mark this issue as a "won't fix" + "feature request". It can be re-opened when there's a stable pattern to deal with jQuery UI themes that is fully integrated into Drupal and that gives sites control of how the dialogs look.