neither the fullscreen or autostart options take any effect. Attached patch seems to fix this.
diff -Naur ../flvmediaplayer/players/jw_player_4.x.inc ./players/jw_player_4.x.inc
--- ../flvmediaplayer/players/jw_player_4.x.inc 2009-05-01 17:55:59.000000000 +0100
+++ ./players/jw_player_4.x.inc 2009-05-01 17:55:55.000000000 +0100
@@ -307,15 +307,15 @@
'#collapsed' => true,
);
- $form['playback']['param_fullscreen'] = array(
+ $form['playback']['param_allowfullscreen'] = array(
'#title' => t('Allow fullscreen'),
'#type' => 'checkbox',
'#return_value' => 'true',
- '#default_value' => $config['param_fullscreen'],
+ '#default_value' => $config['param_allowfullscreen'],
'#description' => t('Enable fullscreen display'),
);
-
- $form['playback']['flvmp_autostart'] = array(
+
+ $form['playback']['flashvar_autostart'] = array(
'#title' => t('Autostart'),
'#type' => 'checkbox',
'#default_value' => $config['flashvar_autostart'],
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | flvmediaplayer-fullscreen-autostart-fix.patch | 974 bytes | mrfelton |
| #1 | flvmediaplayer-fullscreen-autostart.patch | 1.27 KB | mrfelton |
| flvmediaplayer-fullscreen-autostart.patch | 895 bytes | mrfelton |
Comments
Comment #1
mrfelton commentedUPDATE:
The paramater 'allowscriptaccess' must be set to 'always' not 'true' in order to work in all browsers. When set to 'true', fullscreen does not work in IE. This updated patch also changes the paramater value for allowscriptaccess to 'always'
Comment #2
mrfelton commentedComment #3
arthurf commentedThanks, these are committed to the dev branch
Comment #4
arthurf commentedComment #6
mrfelton commentedYou did not apply the updated patch, and so allowscriptaccess is still set to 'true', which is incorrect - it should be 'always' as per my patch at #1
Comment #7
mrfelton commentedActually, it seems that you have muddled the values for fullscreen and autostart. Please apply this patch to correct.