Incorrect variable typos and profile_load_profile() bugs
v1nce - May 2, 2009 - 17:17
| Project: | Campaign Monitor |
| Version: | 5.x-2.1 |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | ssherriff |
| Status: | closed |
Jump to:
Description
1. correct typo in admin form $form['campaignmonitor_checkboxisplaytext'] should be $form['campaignmonitor_checkboxdisplaytext']
2. The checkboxdisplaytext form item should not be limited to only 50 characters.
3. corrected incorrect variable_get call in campaign_user_form - variable_get('campaignmonitor_user_pagedisplaytext', 'Newsletter'), should be variable_get('campaignmonitor_userpagedisplaytext', 'Newsletter'),
4. profile_load_profile() requires a $user object and not merely the uid
| Attachment | Size |
|---|---|
| campaignmonitor_module.patch | 1.48 KB |
#1
Looks okay, except the last hunk has spacing problems; make sure you do not use tabs (according to the Coding Standards).
#2
I use spaces for indention. You can see the only thing I changed was passing in the $user object instead of the uid. Any spacing issues were in the original module.
- profile_load_profile($user->uid);+ profile_load_profile($user);
#3
#4
Ok, thank you, will check, apply and update on next release.
#5
Ok, added to latest release.
#6
Since this is marked fixed, I'll put this advice here. I maintain over 20 modules, so I have some experience with Drupal adopters. I recommend, but you are free to ignore me, that you turn on the -dev feature and put your fixes out for testing there first, rather than rolling out a new release with every couple of fixes. It is kind of strange, but your users will complain even more loudly if you roll releases out too quickly. One thing I started doing some time ago was to keep a running list of the -dev fixes on the project page; not only does this let people know what's being tested, but also becomes an easy-to-copy list for the release notes. A good example of this is in Web Links. I try to not roll out an official release more than once a month. This process seems to be making the users happier.
#7
Automatically closed -- issue fixed for 2 weeks with no activity.