Calling this a bug because it can disrupt themes. I'm new to Drupal, but get the impression that using the API for ease in theming and consistency in UI is a core value within the project, so it seemed this was more in the "bug" realm...
Repeatable: Always
Steps to repeat:
- Theme the "links" list at the top of various Forums pages (aka, "instructions list", "Create new forum topic" link, "disallowed message", etc)
- Install OG Forums and convert to using the OG Forums module.
- Visit the forums list page or a single forum page.
Expected Results:
Depending on the theme CSS and overriding theme functions, the corresponding items in the list would be themed the same as they were when using the Forums module or as other "links" lists.
Actual Results:
The items in the list are not necessarily themed similarly to the corresponding list at the top of Forums pages or other "links" lists.
Detail & Proposed solution:
Forums module uses theme('links',...) to generate the links at the top of the forum pages, which creates the CSS environment in that <ul>.
OG Forums hard-codes this <ul>, resulting in HTML that's inconsistent with that at the top of the Forums module (theme_og_forum_display(), ~418-440).
While it would be easy to throw 'class="links"' into the <ul> and other classes into the various <li> items in theme_og_forum_display(), a more robust approach would be to use theme('links',...) to allow for easier theme override & consistentency with other "links" lists.
I'll get a patch up as soon as I can.
Comments
Comment #1
Anonymous (not verified) commentedThanks for your detailed bug report.
If you would submit a patch, ill get that reviewed promptly.
Best, Paul
Comment #2
vegantriathlete