warning in site settings

bluetegu - May 3, 2009 - 07:07
Project:Subscriptions
Version:5.x-2.4
Component:Code
Category:bug report
Priority:minor
Assigned:Unassigned
Status:closed
Description

Hi,

Thanks for the module.

I got the following warnings when I pressed the site-settings tab in subscriptions admin settings.

* warning: array_merge() [function.array-merge]: Argument #1 is not an array in mysite/includes/menu.inc on line 415.
* warning: Missing argument 1 for drupal_get_form() in mysite/includes/form.inc on line 49.
* warning: Missing argument 1 for drupal_retrieve_form() in mysite/includes/form.inc on line 179.
* warning: call_user_func_array() [function.call-user-func-array]: First argument is expected to be a valid callback, '' was
given in mysite/includes/form.inc on line 218.

Attached is a patch that removes the warning.

Remember to clear cache after installing the patch.

Feedback appreciated.

Best,
Bluetegu

AttachmentSize
subscription-sitesetting-warning.patch480 bytes

#1

salvis - May 3, 2009 - 20:59

Hmm, you must be manually entering admin/settings/subscriptions/settings, right? Why?

When I click on "Site settings," then I get to admin/settings/subscriptions, which works just fine.

How can you even find out that admin/settings/subscriptions/settings exists, short of reading the code? It's the MENU_DEFAULT_LOCAL_TASK and it usually doesn't need any callback, because it relies on the parent's callback.

#2

bluetegu - May 3, 2009 - 21:37

Hi Salvis,

I went over the different tabs browsing and configuring the parameters listed in each page. When I finished going over 'user defaults' and 'Interval' tabs I wanted to go back to the 'site setting' tab and once you press it you go subscription/settings. Please try it and see whether you get the same warnings I got.

Thanks,
Bluetegu

#3

salvis - May 3, 2009 - 22:16

No, when I'm on admin/settings/subscriptions/intervals and I click on the "Site settings" tab, then I get to admin/settings/subscriptions, not admin/settings/subscriptions/settings!

Maybe it's your adding the callback that causes the link to change?

#4

bluetegu - May 3, 2009 - 22:33

I got the warnings before I added the callbacks. I'm not sure why I'm seeing these warnings while you do not. If no one else complains I guess you can just close this issue.
Best,
Bluetegu

#5

salvis - May 3, 2009 - 22:46

I see the warnings on admin/settings/subscriptions/settings, but I can only get there by manually typing in the path. I don't see any link that would lead there.

My "Site settings" links all go to admin/settings/subscriptions, which is synonymous to admin/settings/subscriptions/settings, because the latter is the MENU_DEFAULT_LOCAL_TASK, but there aren't any warnings when accessed via the parent path.

Are you maybe using some kind of module that modifies the menu, makes it available via JavaScript, or something like that? Or maybe it's a theming issue? Does it happen on Garland?

#6

bluetegu - May 4, 2009 - 09:33

I'm using Tendu template and administration menu. Nothing I can think about that fiddles with the menu. Since I have many modules in this installation (its a development environment) I do tend to look at code and type in by hand sometimes. I can't recall if I initially typed the url by hand or not here, although I don't think I did. In any case since I got this warning repeatably while using the subscriptions menu tabs I added the patch to avoid it.

#7

salvis - May 4, 2009 - 18:09

administration menu

That's probably what makes the difference — have you tried to temporarily disable it?

#8

salvis - June 3, 2009 - 18:46

I've installed admin_menu 5.x-2.8, but I still don't see the error that you describe...

Can it be the template? I've set blue-marine as my administration template.

#9

salvis - July 3, 2009 - 09:11
Status:needs review» fixed

Assuming this is fixed.

#10

System Message - July 17, 2009 - 09:20
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.