Style issues with inline images

dmuth - January 18, 2006 - 05:08
Project:Acidfree Albums
Version:4.6.x-1.x-dev
Component:Code
Category:bug report
Priority:minor
Assigned:Unassigned
Status:by design
Description

I noticed that when displaying an inline image with [acidfree:xxx] tags, that the image would always be aligned to the left, which I didn't want for the site I was building.

I tracked down the source of this to _acidfree_filter_tag(), which adds the HTML align='left'. I removed that code and now I can position the inline images however I like.

I have attached the diff.

(And, on an unrelated note, thanks for writing Acidfree. I've had a lot of fun building galleries of my pictures with it.)

-- Doug

AttachmentSize
acidfree-inline.diff.txt1.18 KB

#1

vhmauery - January 18, 2006 - 06:02
Status:needs review» by design

it doesn't add align='left', it lets you specify with the filter align=left or align=right and then uses inline css 'float: left' or 'float: right' according to what you specified.

try a tag like [acidfree:xxx align=right]

#2

dmuth - January 18, 2006 - 19:08

So... if I understand correctly, align=left is the default alignment, but it can be overridden with syntax like what you provided?

#3

vhmauery - January 18, 2006 - 19:54

yes, just make your tag look like [acidfree:1234 align=right]

#4

dmuth - January 19, 2006 - 23:19

Okay. Thanks for clarfying that.

On that note, I don't see anything in the help section of the module that mentions that. Mind if I submit a patch that mentions this feature? :-)

-- Doug

#5

vhmauery - January 20, 2006 - 05:03

Sure, you can make a patch. But just in my defense, the README does explain it. But neither the Acidfree Manual nor the online filter tip help page talk about it currently. The manual is actually not done yet and it has been a while since I have worked on it. I will have to remember to add this to the manual when I do work on it next.

 
 

Drupal is a registered trademark of Dries Buytaert.