In uc_store.module, function uc_store_token_values(), two tokens ([store-url] and [store-link]) are defined which use the value of 'uc_store_url' retrieved from the variable table. However, 'uc_store_url' is never set anywhere, so variable_get('uc_store_url', $base_url) always returns the default value of $base_url.

The other variables used to define tokens, such as 'uc_store_name', 'uc_store_owner', etc., are all set by the store administrator through the form uc_store_store_settings_form() (reached at admin/store/settings/store/edit).

I don't know if this omission is deliberate or not. I suggest either changing uc_store_store_settings_form() to allow the admin to specify a 'uc_store_url', or simply eliminating all reference to this variable and let $base_url be used explicitly instead of variable_get('uc_store_url', $base_url).

Comments

Island Usurper’s picture

Priority: Normal » Minor
Status: Active » Fixed

I see no problem with that. Committed.

tr’s picture

Status: Fixed » Closed (fixed)