Posted by elvis2 on May 4, 2009 at 10:33am
Jump to:
| Project: | Comment Luv |
| Version: | 5.x-1.1-beta1 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (won't fix) |
Issue Summary
Thanks for making this for the Drupal community.
After reviewing this module, I found a few things I would like to note:
- Add watchdog support, to pickup magpie returned errors. Like so:
// try typepad own domain
if(!$rss) {
$feed_url="$author_url/atom.xml";
$rss=fetch_rss("$feed_url");
}
}
watchdog('CommentLuv', $rss);
// **************************
// *** do the parse dance ***
// **************************- many times people put in the short version of their website when adding comments, IE:
--- elvisblogs.org
--- http://elvisblogs.org
Instead of http://www.elvisblogs.org I think your code should look for errors from magpie and if errors retry with and without "www" and "http".
- I wonder if the comment should be approved first before calling getting the comment's last post?
Thanks again for working on this module.
Comments
#1
The 6.2 branch does not work with mapgie rss anymore, now this rss fetch is done through feeds module. Please, use #337535: The future of Commentluv issue for feature suggestions.
There won't be support anymore for 6.1 branch
Thanks.