IP to Locale - functionality overlap/duplication
| Project: | Country code |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | support request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Hi,
I'm just writing to make you all aware that I have just created a duplicate project (by accident)!!
http://drupal.org/project/ip2locale
I found myself in a situation where I needed to redirect users to a site version (locale) based on their location (IP address). After Stella notified about your module, I was keen to take a look, obviously! It seems you are doing a very similar thing to me, but yours is perhaps a little more evolved. A couple of things I did notice though:
1) you provide a means of specifying which country code handler should be used, but do not allow for using more than one handler (should a handler fail to provide a match). In my module, I had a dedicated 'backend' (handler) managerment page, allowing uses to enable, disable and order available backends with drap/drop.
2) Once the users country code has been identified, it is stored in a session var (nice) but there seems to be no way to clear this, which makes debugging really difficult. Actually, _country_code_reset() is supposed to do this, but it only gets called upon submission of the modules page, and doesn't actually with the session var anyway.
3) A nice addition for debugging purposes, which I included in ip2locale, is to allow users to pass in an IP address via $_GET - saves messing with settings.php, which many people don't have access to.
Anyway, I'll probably end up abandoning ip2locale in favour of country_code, as it does seem to be a little further down the road (mine was whipped up in a day!) - so expect to hear more from me!! If you want to add me as a project maintainer I'll be happy to provide whatever input I can, and of course, follow what ever commiting policy you have.
