Posted by jdwfly on May 4, 2009 at 4:21pm
| Project: | Webform Associate |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed (won't fix) |
Issue Summary
After installing this module I realized that my cron.php wouldn't run, but instead it redirected itself back to one of my webform associated nodes. After much research I found out that drupal_goto is usually the culprit so I went in and added a conditional to the line that was doing the redirect.
NOTE
This patch was made using the most recent dev version
Comments
#1
#2
This is a CRITICAL bug because it breaks site search indexing and cron runs when webform associations are in use.
The patch in #1 didn't work for me because
$_SERVER['SCRIPT_NAME']was not/cron.phpwhen I checked its value - it might be on a proper cron run, but when choosing 'Run cron' it was not.So I think the line top of function webform_associate_nodeapi should look like this instead:
<?phpfunction webform_associate_nodeapi(&$node, $op, $a3 = NULL, $a4 = NULL) {
if ($node->type == 'webform' && $op == 'view') {
$ids = webform_associate_lookup($node->nid, 'wid');
=> if ($ids && $_SERVER['REQUEST_URI'] != '/admin/reports/status/run-cron') {
drupal_goto('node/' . $ids->nid);
}
}
?>
...Or is there a better/correct way of knowing we're in a cron run?
#3
@Jim -- hope you hear back soon...this may be useful for something I'm working on.
#4
The features of this module are now included IN webform 3.x. This module is now obsolete.