It seems that many people like the MLT feature and it seems a bit silly to have it as a separate module.

At the least, we could better re-use the existing blocks admin interface.

CommentFileSizeAuthor
#12 move-mlt-framework-453338-12.patch39.21 KBpwolanin
#11 move-mlt-framework-453338-11.patch21.84 KBJacobSingh
#9 move-mlt-framework-453338-9.patch38.32 KBpwolanin
#8 move-mlt-framework-453338-8.patch38.26 KBpwolanin
#7 simplify-mlt-453338-7.patch25.52 KBpwolanin
#6 simplify-mlt-453338-6.patch24.2 KBpwolanin
#4 simplify-mlt-453338-4.patch22.43 KBpwolanin
#3 simplify-mlt-453338-3.patch20.77 KBpwolanin
#2 simplify-mlt-453338-2.patch20.77 KBpwolanin
#1 simplify-mlt-453338-1.patch20.17 KBpwolanin

Comments

pwolanin’s picture

pwolanin commented
Status: Active » Needs review
StatusFileSize
new simplify-mlt-453338-1.patch20.17 KB

Here's a patch that simplifies things quite a bit - I'm a little unsure whether we should actually roll this into one of the other modules since that will make the checks on the module and delta attributes a little harder.

pwolanin’s picture

pwolanin commented
StatusFileSize
new simplify-mlt-453338-2.patch20.77 KB

A little more, but somehow not working...

pwolanin’s picture

pwolanin commented
Title: Include MLT module into the search or framework module » Simplfy MLT module and possibly roll into framework module
StatusFileSize
new simplify-mlt-453338-3.patch20.77 KB

ok, now working - jsut missed one variable conversion.

pwolanin’s picture

pwolanin commented
StatusFileSize
new simplify-mlt-453338-4.patch22.43 KB

Fixed a fatal error and clean up the form a little more.

robertdouglass’s picture

robertdouglass commented

from scanning the patch I think I like this idea. Just to confirm - all MLT blocks will have the same level of configurability? Seems so from the patch.

Next step after this: decouple getting MLT recommendations from "blocks" altogether so that they can be used as a normal API.

pwolanin’s picture

pwolanin commented
StatusFileSize
new simplify-mlt-453338-6.patch24.2 KB

@robert - this does not change configurability at all - just relocates the configuration to the actual per-block configuration form.

Easy enough to take one more step to make the core MLT function more of an API than before.

pwolanin’s picture

pwolanin commented
StatusFileSize
new simplify-mlt-453338-7.patch25.52 KB
pwolanin’s picture

pwolanin commented
StatusFileSize
new move-mlt-framework-453338-8.patch38.26 KB

With some minor hacking wrt the delta, we can just move this into the framework like so. How does this seem?

pwolanin’s picture

pwolanin commented
StatusFileSize
new move-mlt-framework-453338-9.patch38.32 KB

A couple more little fixes.

janusman’s picture

janusman commented
Status: Needs review » Reviewed & tested by the community

Tested under latest 6.x-1.x-DEV

JacobSingh’s picture

JacobSingh commented
StatusFileSize
new move-mlt-framework-453338-11.patch21.84 KB

Works good.

I made one tiny change to make the message after being redirected a little more digestible.

It would be nice to include a "What's that?" link next to add new recommended content block when we have some docs.

pwolanin’s picture

pwolanin commented
Status: Reviewed & tested by the community » Fixed
StatusFileSize
new move-mlt-framework-453338-12.patch39.21 KB

committed with one more minor change - make the compaison field checkboxes required so that at least one must be selected.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.