Empty Notifications fieldset [#453578]

Greatly appreciate the great service this module provides!

When a content type is set to allow subscriptions for that content type, AND the content type has comments enabled, an empty Notifications fieldset (expanded) shows up underneath the "Add new comment" box. I noticed this with an existing content type after upgrading to 6.x-2.0, so I tried creating a new content type and got the same results.

I'm going to add in some jquery for now to hide it from users. It doesn't do anything at all, but it may be misleading for some users.

Thanks!

Comment	File	Size	Author
#4	notification_fieldset.patch	2.77 KB	michaelfavia
#1	notifications_disable_fieldset.patch	895 bytes	mshaver

Comments

Comment #1

mshaver commented 4 May 2009 at 21:11

Status:

Active

» Needs review

Status	File	Size
new	notifications_disable_fieldset.patch	895 bytes

This is actually the fieldset for the "skip notifications" functionality. I just noticed this as well and it appears because the fieldset doesn't have the access permission on it as well. Here is a patched version.

Comment #2

swellbow commented 5 May 2009 at 14:57

Status:

Needs review

» Reviewed & tested by the community

Worked perfectly. Thanks so much!

Comment #3

michaelfavia commented 7 May 2009 at 16:16

I ran into the same issue and created a similar patch. Is this fieldset used by any other modules at this time?

If SO then this access check is overly specific and will fail them. We might need some sort of FAPI "#after_build" function to determine if it is empty and prune it instead.

Alternatively we can just have each add to it in the same way that this one did. Using #attribute specific variables so as not to reset the fieldset contents that another might create.

If NOT then lets remove the fieldset in the firstplace and make the form easier to understand.

Ill submit a modified patch that conditionally adds the notifications fieldset "carefully" if they have the necessary permission to skip notifications. This is at least extensible until we hear from Jose.