Posted by edegro on May 5, 2009 at 5:22am
5 followers
| Project: | Custom Links |
| Version: | 6.x-1.4 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Issue Summary
I wanted to replace the node 'Read More' link for some of my node types so I grabbed this module and added options to remove them if I'm displaying my own link. I also added a text field for the title attribute on the anchor.
| Attachment | Size |
|---|---|
| custom_links-remove_links_and_attr_title.patch | 8.02 KB |
Comments
#1
this one doesn't include the .info stuff from drupal.org
#2
Subscribe - this feature would be very useful.
#3
many incorrect formatting changes at the beginning of the file (just adding a space)
#4
It looks like the patch does not apply cleanly to 6.x-1.4
It says "Reversed (or previously applied)" when applying the patch on freshly installed 6.x-1.4
Even the title attribute option alone would be greatly appreciated
# patch < custom_links-remove_links_and_attr_title_0.patch
# patching file custom_links.admin.inc
# Reversed (or previously applied) patch detected! Assume -R? [n] y
# Hunk #2 FAILED at 69.
# Hunk #3 FAILED at 150.
#5
Hi,
I created another patch here #918118: improve function _custom_links_build_links that does something else, but you could use it to reproduce same functionality with a theming and its less invasive, but it requires manual labor of theming.
Another thing is that if we start making options of what goes in $links, other contrib modules needs options too, like flag links f. ex.
More discussion is needed on what we want and how we want and which way is better...
#6
Also other attributes needed - class with link key f. example.