Print email addresses after errors as well

mvc - May 5, 2009 - 21:00
Project:Mass Contact
Version:5.x-2.4
Component:User interface
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed
Description

While the basic problem here is that drupal_mail() can't give any more useful information than php's mail(), it would help to have some more feedback after a problem than simply "X errors encountered sending message. Please check the logs and try again." In particular, if run on a shared host without access to mail server log files, it can be hard to figure out what happened, so it would be nice to be given as much feedback as possible. Sometimes one batch of addresses might be sent successfully and other not, so it would be helpful to know if that happened. In addition, the current error message implies that the watchdog log as a record of problems with the mail delivery, and that's not the case.

I don't think this is needlessly verbose, since it doesn't print any more text than it would if the mail delivery succeeded.

AttachmentSize
error_reporting.patch1.78 KB

#1

oadaeh - May 21, 2009 - 01:43
Category:bug report» support request
Status:needs review» fixed

I made changes to the way the messages are presented and logged here: http://drupal.org/cvs?commit=214392

I didn't do it exactly the way you suggested, but close. I put the messages in watchdog, rather than the main screen.

#2

oadaeh - May 21, 2009 - 01:44
Category:support request» feature request

Setting the category.

#3

System Message - June 4, 2009 - 01:50
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.