Posted by FiNeX on May 6, 2009 at 9:19am
Jump to:
| Project: | UC Purchase Order |
| Version: | 6.x-1.0 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Issue Summary
I'd like to have an option to skip the manual PO number insertion.
I've already done a patch for implementing this feature:
http://drupal.org/node/361880#comment-1255600
If needed, I can create a new patch for the latest version of the module.
Comments
#1
Unfortunately the linked patch fails against both current 6.x-1.x and 6.x-2.x-dev versions of uc_po.
#2
Well, it has been done 7 months ago, it is reasonable.
@xurizaemon: if I'll update the patch for the current 2.x-dev version, will it be included? Otherwise I'll give to this task a lower priority. Thanks!
#3
@Finex, yes it's to be expected that patches may not apply after a period of continued development. Just pointing it out so you'd have a chance to update it if you still want this feature considered for inclusion.
I'm not the maintainer so I'd by lying to tell you that it WILL be accepted - perhaps one of the maintainers can give you some feedback on whether this change will be considered. It might be that this is something done easily enough in hook_form_alter(), which might mean that there's not a huge amount of demand for this feature addition. I honestly don't know, though. If I were you and wanted this feature added, I'd chase rszrama up in IRC for a quick chat.
While I can't reassure you that if the patch does apply it will be accepted, it's probably a fair bet that if it doesn't apply, then it won't be accepted. :)
#4
Of course, I'll try to do something on the next winter holidays :-)
#5
If you don't really need a manual PO number, you might consider using the "other" payment method. I submitted a patch to Ubercart which makes it possible to change the label, so you could easily change it to "Purchase Order": #865136: Ability to rename "Other" payment method.
Give it a shot, and if it makes sense, please vote on it so it gets implemented in Ubercart. Thanks!